Apptesting: Change Interface to Struct #1046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ValarDragon this is just a draft as of now, can you review and see if this was similar to the approach you were thinking of? |
ValarDragon
reviewed
Mar 6, 2022
ValarDragon
reviewed
Mar 6, 2022
Codecov Report
@@ Coverage Diff @@
## main #1046 +/- ##
=======================================
Coverage 20.60% 20.60%
=======================================
Files 193 193
Lines 25237 25237
=======================================
Hits 5199 5199
Misses 19084 19084
Partials 954 954 Continue to review full report at Codecov.
|
ValarDragon
approved these changes
Mar 7, 2022
mergify bot
pushed a commit
that referenced
this pull request
Mar 7, 2022
* Initial Commit * Delete unnecessary lines * Embed suite and keeper helper (cherry picked from commit b27b5b2)
ValarDragon
pushed a commit
that referenced
this pull request
Mar 7, 2022
* Initial Commit * Delete unnecessary lines * Embed suite and keeper helper (cherry picked from commit b27b5b2) Co-authored-by: Matt, Park <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extension for pull #1008.
We should compare this with the interface approach and compare on usability
For contributor use:
docs/) or specification (x/<module>/spec/)Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorer