-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add total superfluid delegation sum invariant #1018
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM to merge once the API comment is resolved
Co-authored-by: Dev Ojha <[email protected]>
Co-authored-by: Dev Ojha <[email protected]>
A couple of options:
|
go.mod
Outdated
github.com/CosmWasm/wasmd => github.com/osmosis-labs/wasmd v0.22.0-osmo-v7.2 | ||
// Our cosmos-sdk branch is: https://github.com/osmosis-labs/cosmos-sdk v0.45.0x-osmo-v7 | ||
github.com/cosmos/cosmos-sdk => github.com/osmosis-labs/cosmos-sdk v0.45.1-0.20220221115656-75545ea8cb2d | ||
github.com/cosmos/cosmos-sdk => github.com/osmosis-labs/cosmos-sdk v0.45.1-0.20220309174635-d81fb5657a15 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you PR the hook addition to the SDK branch, then we can get this merged?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's the PR for after slash hook
https://github.com/osmosis-labs/cosmos-sdk/pull/136/files
Just needs to update the go.mod reference to be merged commit in the SDK branch, and we can get this merged. |
Codecov Report
@@ Coverage Diff @@
## v7.x #1018 +/- ##
==========================================
+ Coverage 20.59% 20.70% +0.11%
==========================================
Files 193 194 +1
Lines 25231 25279 +48
==========================================
+ Hits 5197 5235 +38
- Misses 19082 19088 +6
- Partials 952 956 +4
Continue to review full report at Codecov.
|
Here's cherry picked version of this PR that is to main branch. And closing this. |
Closes: #XXX
Description
For contributor use:
docs/
) or specification (x/<module>/spec/
)Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorer