Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e: automatically bump OSMOSIS_E2E_UPGRADE_VERSION on major releases #4029

Closed
pysel opened this issue Jan 16, 2023 · 1 comment · Fixed by #4173
Closed

e2e: automatically bump OSMOSIS_E2E_UPGRADE_VERSION on major releases #4029

pysel opened this issue Jan 16, 2023 · 1 comment · Fixed by #4173
Assignees
@MasterPi-2124
Labels
C:e2e Help wanted T:auto Automatic items

Comments

@pysel
Copy link
Member

pysel commented Jan 16, 2023 •
edited by p0mvn
Loading

Background

In #3100 we added a Github Action that triggers on new major release and:

  1. creates a new folder for upgrade handler in app/upgrades
  2. increases E2E_UPGRADE_VERSION in Makefile by one
  3. changes app/app.go file

and creates a pull request

I noticed that this action does not bump OSMOSIS_E2E_UPGRADE_VERSION in https://github.com/osmosis-labs/osmosis/blob/main/.vscode/launch.json

Suggested Design

Increase the version to v14 before implementing the script

In addition to those 3 changes that action does, it should also bump the version of OSMOSIS_E2E_UPGRADE_VERSION

Acceptance Criteria

  • Design implemented
  • Link to PR from fork showing this action works
@github-project-automation github-project-automation bot moved this to Needs Review 🔍 in Osmosis Chain Development Jan 16, 2023
@pysel pysel added feature New feature or request T:auto Automatic items Help wanted and removed feature New feature or request labels Jan 16, 2023
@pysel pysel mentioned this issue Jan 16, 2023
Closed
@pysel pysel added the C:e2e label Jan 16, 2023
@MasterPi-2124
Copy link
Contributor

There are 2 issues #3628 and #3632 related to this, and I created a pr #4031. I think we will need to work on that before doing this issue. Can you guys take a look into that? @p0mvn @rusakh ?

@pysel pysel assigned pysel and MasterPi-2124 and unassigned pysel Jan 18, 2023
@p0mvn p0mvn moved this from Needs Review 🔍 to Todo 🕒 in Osmosis Chain Development Jan 25, 2023
@MasterPi-2124 MasterPi-2124 mentioned this issue Jan 31, 2023
Merged
@github-project-automation github-project-automation bot moved this from Todo 🕒 to Done ✅ in Osmosis Chain Development Jan 31, 2023
p0mvn pushed a commit that referenced this issue Feb 1, 2023
@mergify @MasterPi-2124 @pysel
update OSMOSIS_E2E_UPGRADE_VERSION on upgrade handler #4029 (backport #…
b163ad2 
…4173) (#4176)

* update OSMOSIS_E2E_UPGRADE_VERSION variable in .vscode/launch.json (#4173)

(cherry picked from commit 386c9f0)

# Conflicts:
#	scripts/empty_upgrade_handler_gen.sh

* merge conflict fix

---------

Co-authored-by: Master Pi <[email protected]>
Co-authored-by: Ruslan Akhtariev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MasterPi-2124 MasterPi-2124

Labels
C:e2e Help wanted T:auto Automatic items
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update OSMOSIS_E2E_UPGRADE_VERSION on upgrade handler #4029 notional-labs/osmosis
2 participants
@pysel @MasterPi-2124