Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/mint: refactor, document and unit test keeper's DistributeMintedCoin #1916

Closed
p0mvn opened this issue Jun 30, 2022 · 1 comment · Fixed by #2073
Closed

x/mint: refactor, document and unit test keeper's DistributeMintedCoin #1916

p0mvn opened this issue Jun 30, 2022 · 1 comment · Fixed by #2073
Assignees
Labels
C:docs Improvements or additions to documentation T:task ⚙️ A task belongs to a story T:tests

Comments

@p0mvn
Copy link
Member

p0mvn commented Jun 30, 2022

Background

This is a follow-up to #1839

DistributeMintedCoin does too many things and violates the separation of concerns. It should be refactored to focus on one thing and potentially call other methods.

Suggested Design

Acceptance Criteria

  • the suggested refactor is complete to extract 2 functions:
  1. For developer rewards distribution
  2. Reusable function for distributing staking, pool incentives and community pool rewards.
  • the newly extracted methods are fully covered by unit tests
  • other tests continue to pass

@p0mvn p0mvn added C:docs Improvements or additions to documentation T:tests T:story A story belongs to an epic labels Jun 30, 2022
@ValarDragon ValarDragon moved this to Needs Review 🔍 in Osmosis Chain Development Jun 30, 2022
@p0mvn p0mvn added T:task ⚙️ A task belongs to a story and removed T:story A story belongs to an epic labels Jun 30, 2022
@p0mvn
Copy link
Member Author

p0mvn commented Jun 30, 2022

Marking this as blocked by #1915.

This is better be done after the existing tests are understood and refactored

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:docs Improvements or additions to documentation T:task ⚙️ A task belongs to a story T:tests
Projects
Archived in project
1 participant