Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/mint: understand and refactor keeper tests #1915

Closed
p0mvn opened this issue Jun 30, 2022 · 3 comments · Fixed by #1952
Closed

x/mint: understand and refactor keeper tests #1915

p0mvn opened this issue Jun 30, 2022 · 3 comments · Fixed by #1952
Assignees
@vuong177
Labels
C:docs Improvements or additions to documentation C:x/mint T:story A story belongs to an epic T:tests

Comments

@p0mvn
Copy link
Member

p0mvn commented Jun 30, 2022 •
edited
Loading

Background

This is a follow-up to #1839

Some tests in x/mint keeper are complex and poorly understood. We need to refactor them for clarity if applicable. This includes:

  • TestMintCoinsToFeeCollectorAndGetProportions
  • TestDistrAssetToDeveloperRewardsAddrWhenNotEmpty

Acceptance Criteria

  • investigate the above tests
  • refactor if needed
  • add comments to make them clear
@p0mvn p0mvn added C:docs Improvements or additions to documentation T:tests T:story A story belongs to an epic labels Jun 30, 2022
@ValarDragon ValarDragon moved this to Needs Review 🔍 in Osmosis Chain Development Jun 30, 2022
@p0mvn p0mvn added the C:x/mint label Jun 30, 2022
@p0mvn p0mvn mentioned this issue Jun 30, 2022
Closed
@vuong177
Copy link
Contributor

vuong177 commented Jul 4, 2022

Hi @p0mvn. Could I work on this issue?

@vuong177 vuong177 mentioned this issue Jul 4, 2022
Merged
@p0mvn
Copy link
Member Author

p0mvn commented Jul 4, 2022

Hi @vuong177

Yes, thanks for picking this up.

I saw that you've already made good progress. I really appreciate the initiative but I would like to ask you to please wait for a reply next time before starting work. Some of the issues might not be groomed enough yet / not decided on. I just would like to avoid having you spend time on something that we might end up not pursuing in the end.

@vuong177
Copy link
Contributor

vuong177 commented Jul 4, 2022

Thank you for your advice @p0mvn. I'll ask carefully so as not to waste time!

Repository owner moved this from Needs Review 🔍 to Done ✅ in Osmosis Chain Development Jul 7, 2022
@p0mvn p0mvn mentioned this issue Jul 14, 2022
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vuong177 vuong177

Labels
C:docs Improvements or additions to documentation C:x/mint T:story A story belongs to an epic T:tests
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor keeper tests in x/mint
2 participants
@p0mvn @vuong177