Skip to content

Commit

Permalink
Add a file ignore for check generated running (#5979) (#5981)
Browse files Browse the repository at this point in the history
In our check-generated CI job, make it not run if not needed.
(It just runs make proto-gen && make run-querygen)

Also only setuip go after we pass git diff.

(cherry picked from commit 6b947d0)

Co-authored-by: Dev Ojha <[email protected]>
  • Loading branch information
mergify[bot] and ValarDragon authored Aug 8, 2023
1 parent a089167 commit 5da2a20
Showing 1 changed file with 16 additions and 4 deletions.
20 changes: 16 additions & 4 deletions .github/workflows/check-generated.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,15 +17,27 @@ jobs:
check-proto:
runs-on: ubuntu-latest
steps:
-
uses: actions/checkout@v3
with:
fetch-depth: 1 # we need a .git directory to run git diff
-
name: Get git diff
uses: technote-space/[email protected]
with:
PATTERNS: |
proto/**
**/**.pb.go
**/client/**.go
scripts/ci/**
Makefile
Dockerfile
.github/workflows/check-generated.yml
-
name: 🐿 Setup Golang
uses: actions/setup-go@v4
with:
go-version: '^1.20'
-
uses: actions/checkout@v3
with:
fetch-depth: 1 # we need a .git directory to run git diff
-
name: "Check protobuf generated code"
run: scripts/ci/check-generated.sh

0 comments on commit 5da2a20

Please sign in to comment.