Backport of https://github.com/cosmos/cosmos-sdk/pull/18959 #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -19,7 +19,8 @@ | |||
| // Iterate over all the validators which *should* have signed this block | |||
| // store whether or not they have actually signed it and slash/unbond any | |||
| // which have missed too many blocks in a row (downtime slashing) | |||
| params := k.GetParams(ctx) | |||
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods Warning
There was a problem hiding this comment.
we already had this panic path alas
| for _, voteInfo := range req.LastCommitInfo.GetVotes() { | ||
| k.HandleValidatorSignature(ctx, voteInfo.Validator.Address, voteInfo.Validator.Power, voteInfo.SignedLastBlock) | ||
| k.HandleValidatorSignatureWithParams(ctx, params, voteInfo.Validator.Address, voteInfo.Validator.Power, voteInfo.SignedLastBlock) |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods Warning
mergify bot
pushed a commit
that referenced
this pull request
Feb 23, 2024
(cherry picked from commit c4a2b32)
mergify bot
pushed a commit
that referenced
this pull request
Feb 23, 2024
(cherry picked from commit c4a2b32)
This was referenced Feb 23, 2024
mergify bot
pushed a commit
that referenced
this pull request
Feb 23, 2024
(cherry picked from commit c4a2b32)
ValarDragon
added a commit
that referenced
this pull request
Feb 23, 2024
(cherry picked from commit c4a2b32) Co-authored-by: Dev Ojha <[email protected]>
ValarDragon
added a commit
that referenced
this pull request
Feb 23, 2024
(cherry picked from commit c4a2b32) Co-authored-by: Dev Ojha <[email protected]>
ValarDragon
added a commit
that referenced
this pull request
Feb 23, 2024
(cherry picked from commit c4a2b32) Co-authored-by: Dev Ojha <[email protected]>
19 tasks
czarcas7ic
pushed a commit
that referenced
this pull request
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slight state compatible speedup to slashing.GetParams
This is a .3% state machine processing time speedup on IAVL v0, .5% on v1 no fast nodes.
Backporting this to more easily backport our more significant write reduction PR we made upstream.