fix: proofs query to help debug app hash #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderbez
reviewed
Apr 7, 2022
| @@ -1048,7 +1048,7 @@ func (rs *Store) doProofsQuery(req abci.RequestQuery) abci.ResponseQuery { | |||
| } | |||
|
|
|||
| for _, storeInfo := range commitInfo.StoreInfos { | |||
| res.ProofOps.Ops = append(res.ProofOps.Ops, commitInfo.ProofOp(storeInfo.Name)) | |||
| res.ProofOps.Ops = append(res.ProofOps.Ops, crypto.ProofOp{Key: []byte(storeInfo.Name), Data: storeInfo.CommitId.Hash, }) | |||
There was a problem hiding this comment.
Is this same logic that exists in the SDK?
There was a problem hiding this comment.
No, this was only added here to help debug the app hash problem. Basically, I need a query to see each substore's hash at a specified height.
That should help determine which store committed wrong data.
alexanderbez
approved these changes
Apr 7, 2022
mergify bot
pushed a commit
that referenced
this pull request
Apr 7, 2022
(cherry picked from commit 66442bf)
p0mvn
added a commit
that referenced
this pull request
Apr 12, 2022
(cherry picked from commit 66442bf) Co-authored-by: Roman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This functionality was implemented in #156
I realized that I need a different hash to help with determining which store was faulty upon getting the app hash error. This PR fixes it.