refactor: Fixes the go race tests #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We used these iterators with no mutex, back when iterator performance was one of our main blockers, and this step was thought to be of heavy performance impact. (It does add a notable delay to iteration steps, but it was later learned the bulk of the problem was due to IAVL & LevelDB interaction) Its overdue to have turned this off just for simplicity of tests passing. We still should update the BTree library and remove the need for this multiple process terrible hack that exists now, but thats work for the future. (There is no race condition if you look into the details of whats happening, the gorace detector is off here!)
alexanderbez
changed the title
|
@ValarDragon what's up with the failing tests? Are they related? |
|
IDK whats going on with the build failures. test-race (00) seems like a different race condition. CC @p0mvn for that one |
|
I think this has to do with We can tweak the timeout value here: cosmos-sdk/baseapp/baseapp_test.go Line 144 in d53f1dd Feel free to merge this PR, I can find the right value for the timeout in a separate PR Update: created issue to keep track of this |
|
@Mergifyio backport v0.45.0x-osmo-v8 |
mergify bot
pushed a commit
that referenced
this pull request
Apr 15, 2022
We used these iterators with no mutex, back when iterator performance was one of our main blockers, and this step was thought to be of heavy performance impact. (It does add a notable delay to iteration steps, but it was later learned the bulk of the problem was due to IAVL & LevelDB interaction) Its overdue to have turned this off just for simplicity of tests passing. We still should update the BTree library and remove the need for this multiple process terrible hack that exists now, but thats work for the future. (There is no race condition if you look into the details of whats happening, the gorace detector is off here!) (cherry picked from commit bd83477)
✅ Backports have been created
|
ValarDragon
added a commit
that referenced
this pull request
Apr 15, 2022
We used these iterators with no mutex, back when iterator performance was one of our main blockers, and this step was thought to be of heavy performance impact. (It does add a notable delay to iteration steps, but it was later learned the bulk of the problem was due to IAVL & LevelDB interaction) Its overdue to have turned this off just for simplicity of tests passing. We still should update the BTree library and remove the need for this multiple process terrible hack that exists now, but thats work for the future. (There is no race condition if you look into the details of whats happening, the gorace detector is off here!) (cherry picked from commit bd83477) Co-authored-by: Dev Ojha <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used these iterators with no mutex, back when iterator performance was
one of our main blockers, and this step was thought to be of heavy performance impact.
(It does add a notable delay to iteration steps, but it was later learned
the bulk of the problem was due to IAVL & LevelDB interaction)
Its overdue to have turned this off just for simplicity of tests passing.
We still should update the BTree library and remove the need for this
multiple process terrible hack that exists now, but thats work for the future.
(There is no race condition if you look into the details of whats happening,
the gorace detector is off here!)
Description
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change