Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InstantUndelegate #117

Merged
merged 4 commits into from
Feb 20, 2022
Merged

InstantUndelegate #117

merged 4 commits into from
Feb 20, 2022

Conversation

UnityChaos
Copy link
Member

Description

Add InstantUndelegate keeper method to x/staking. For use in superfluid.

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov-commenter
Copy link

codecov-commenter commented Feb 20, 2022

Codecov Report

Merging #117 (0ee3ff0) into v0.45.0x-osmo-v7 (f432981) will decrease coverage by 0.00%.
The diff coverage is 64.70%.

Impacted file tree graph

@@                 Coverage Diff                  @@
##           v0.45.0x-osmo-v7     #117      +/-   ##
====================================================
- Coverage             61.02%   61.02%   -0.01%     
====================================================
  Files                   588      588              
  Lines                 37840    37840              
====================================================
- Hits                  23091    23090       -1     
+ Misses                12785    12783       -2     
- Partials               1964     1967       +3     
Impacted Files Coverage Δ
x/staking/keeper/delegation.go 70.51% <64.70%> (-0.22%) ⬇️
store/iavl/store.go 59.84% <0.00%> (-6.10%) ⬇️
x/staking/keeper/hooks.go 30.00% <0.00%> (-0.77%) ⬇️
x/staking/keeper/slash.go 68.65% <0.00%> (-0.47%) ⬇️
store/rootmulti/store.go 68.61% <0.00%> (-0.03%) ⬇️
store/iavl/tree.go 87.50% <0.00%> (ø)
x/distribution/keeper/hooks.go 25.00% <0.00%> (+1.31%) ⬆️
x/staking/types/hooks.go 9.09% <0.00%> (+2.42%) ⬆️
crypto/keys/internal/ecdsa/privkey.go 83.78% <0.00%> (+2.70%) ⬆️
x/slashing/keeper/hooks.go 82.14% <0.00%> (+4.72%) ⬆️

@ValarDragon ValarDragon merged commit 1b4ae82 into v0.45.0x-osmo-v7 Feb 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants