Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make some default mint coins restrictions #49

Closed
4 tasks
ValarDragon opened this issue Jan 5, 2022 · 4 comments
Closed
4 tasks

Make some default mint coins restrictions #49

ValarDragon opened this issue Jan 5, 2022 · 4 comments
Assignees

Comments

@ValarDragon
Copy link
Member

ValarDragon commented Jan 5, 2022

Summary

We need a mintcoins restriction function creator, for easily creating restrictions to only mint coins with the provided prefix. E.g.

// NewPrefixMintCoinsRestriction creates a mint coins restriction fn, that only allows banks to mint coins that have a denom beginning with "...."
func NewPrefixMintCoinsRestriction(prefix string) MintCoinsRestrictionFn {
...
}

Problem Definition

We're going to use this same code for gamm and token factory.

Blocked on #48


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@mattverse
Copy link
Member

mattverse commented Jan 12, 2022

Should I create a PR against #50 branch for this issue?What Im thinking as of now is adding a default mintcoin restriction function creator together with #50 and get it merged and reviewed together.

@mattverse
Copy link
Member

Also do we have an idea on what default minting restriction we want? I'm currently thinking of making a variadic function taking in strings that you would want to restrict minting on

@ValarDragon
Copy link
Member Author

ValarDragon commented Jan 14, 2022

oh interesting idea, I think that makes sense. Basically emits a restriction fn, that blocks emitting anything that starts with any of the variable inputs.

@daniel-farina daniel-farina moved this from 🕒 Todo to 🏃 In Progress in Osmosis Chain Development Jan 17, 2022
@ValarDragon ValarDragon moved this from 🏃 In Progress to ✅ Done in Osmosis Chain Development Jan 21, 2022
@ValarDragon
Copy link
Member Author

Closed in #57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants