merge Softbank

[venue-map]

#4868 has been closed because SoftBank Telecom (Q7553832) and SoftBank Shop (Q11315281) are not integrated, so I edited it.

I understand there are two brands in wikidata for mobile_phone shops:
SoftBank Telecom (Q7553832)
SoftBank Shop (Q11315281)
Are both legitimate and distinct retail chains ?

The Japanese version of Wikipedia clearly states that "SoftBank Telecom has merged with SoftBank Mobile.".

[nuxper]

@bhousel : I'd need your advise here ;) : I'm happy with the proposed pull request : Softbank Telecom was merged in Softbank in 2015 and doesn't seem to exist anymore. However there are still 208 nodes with this brand:wikidata in Japan ( https://overpass-turbo.eu/s/13RP ). Softbank Shop, which I understand is the correct preset now has 391 ( https://overpass-turbo.eu/s/13RQ )

Are there specific steps in this case ? At least remove the name-suggest-index id from wikidata I suppose ? Anything else ? I couldn't find specific instructions in the doc but may have missed them.

[venue-map]

@nuxper -san.

Are there specific steps in this case ? At least remove the name-suggest-index id from wikidata I suppose ? Anything else ? I couldn't find specific instructions in the doc but may have missed them.

I think it's okay to remove the name-suggest-index id from Wikidata.
This is because SoftBank Telecom (Q7553832) does not operate a store.
(Actually, SoftBank Telecom (Q7553832) is not actually involved in the operation of the mobile phone shop.)

[Adamant36]

So, not to over turn the apple cart, but their store signs say "SoftBank." Their social media account says "SoftBank" also. As well as their website. So, where is it officially "SoftBank Shop" and why does it matter in this case what they are "officially" called if they don't use the word "shop" literally anywhere? (I assume there's a space between "SoftBank" and "Shop", but that's a different issue). Or are you just saying that's their "official" name because they are a shop?

(BTW, it looks like there's a ton of build errors with the build scripts in the Files Changed section also. I don't know if it effects the PR any though. Since it still says it passed the checks, but I thought I'd mention it).

[Adamant36]

Minor update, I guess the build errors are caused by the version of Moment being used in the package.json file or something. At least that's the error I got when I did npm run build. It "Can't find module local-compare." I'm not super on my build errors though and it looks like other PRs are having the same problem of showing errors on Githubs end @bhousel.

[bhousel]

from @nuxper

Are there specific steps in this case ? At least remove the name-suggest-index id from wikidata I suppose ? Anything else ? I couldn't find specific instructions in the doc but may have missed them.

The PR looks ok to me, thanks @venue-map 👍 . When we sync up with wikidata our script will remove the NSI identifier from their end automatically, but there is no harm in removing it manually.

from @Adamant36

So, where is it officially "SoftBank Shop" and why does it matter in this case what they are "officially" called if they don't use the word "shop" literally anywhere?

I'm not going to worry about this much, since it's primarily a Japanese brand. The *:en tags are really there for our convenience and might just be simple translations of the Japanese names.

(BTW, it looks like there's a ton of build errors with the build scripts in the Files Changed section also. I don't know if it effects the PR any though. Since it still says it passed the checks, but I thought I'd mention it).

It's ok! these are just warnings. I'll get rid of them soon, but I have been changing a bunch of stuff around in all the files to make it possible to store per-category config values for #4906.

[Adamant36]

It's ok! these are just warnings. I'll get rid of them soon, but I have been changing a bunch of stuff around in all the files to make it possible to store per-category config values for #4906.

Alright. Good to know 👍