Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makefile: implement "fully source containers" HMS-3883 #4056

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Makefile: implement "fully source containers" HMS-3883 #4056

wants to merge 2 commits into from

Conversation

schuellerf
Copy link
Contributor

Getting the stack up and running locally but all from source

also contains a followup of COMPOSER-2185 just to get it compiling

@schuellerf
Copy link
Contributor Author

Note: unit tests fail due to inconsistencies with the images repo - "fixed" in
eef36f7
but the testframework apperently uses the old version of images

@schuellerf schuellerf force-pushed the HMS-3883-fully-source-containers branch 2 times, most recently from f925363 to 2a3aafe Compare April 8, 2024 07:39
@schuellerf schuellerf force-pushed the HMS-3883-fully-source-containers branch from 83e14f4 to 969a11a Compare April 12, 2024 17:30
@schuellerf schuellerf force-pushed the HMS-3883-fully-source-containers branch 2 times, most recently from 20a6bd2 to 51a1d88 Compare April 23, 2024 12:58
@schuellerf schuellerf force-pushed the HMS-3883-fully-source-containers branch from d801e4e to d2259e9 Compare May 8, 2024 17:34
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 8, 2024

This PR is stale because it has been open 30 days with no activity. Remove "Stale" label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jun 8, 2024
@github-actions GitHub Actions
Copy link

This PR was closed because it has been stalled for 30+7 days with no activity.

@github-actions github-actions bot closed this Jun 15, 2024
@schuellerf schuellerf reopened this Sep 6, 2024
@schuellerf schuellerf removed the Stale label Sep 6, 2024
@schuellerf schuellerf force-pushed the HMS-3883-fully-source-containers branch 3 times, most recently from 1c180cf to 3d69ded Compare September 9, 2024 09:27
bcl
bcl reviewed Sep 10, 2024
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@schuellerf schuellerf force-pushed the HMS-3883-fully-source-containers branch from 3d69ded to 33882a5 Compare September 10, 2024 08:16
@schuellerf schuellerf requested a review from bcl September 10, 2024 08:16
@schuellerf schuellerf marked this pull request as ready for review September 10, 2024 08:16
@schuellerf schuellerf force-pushed the HMS-3883-fully-source-containers branch 2 times, most recently from 607ec83 to bc2bb99 Compare September 10, 2024 08:31
@bcl
Copy link
Contributor

bcl commented Sep 10, 2024

Hm, so just quickly trying make container_composer.dev here and this appears to assume things about my repo layouts -- it is trying to run make container.dev in ../osbuild which fails because I don't have the PR for osbuild checked out. I also don't really like the idea of one repo touching paths outside of it (whether or not it is dangerous in practice, it is unexpected).

@schuellerf
Copy link
Contributor Author

The starting point of building the stack "fully from source" and the layout is described here
but you are right all layers already depending on outside source need this description too.
That's why I wanted/need to merge them in-order (as mentioned here )
so I'll revert this to draft and continue the process including the discussions in-order

@schuellerf schuellerf marked this pull request as draft September 11, 2024 11:50
@schuellerf schuellerf force-pushed the HMS-3883-fully-source-containers branch from bc2bb99 to 895cf54 Compare October 3, 2024 16:52
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 3, 2024

This PR is stale because it has been open 30 days with no activity. Remove "Stale" label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Nov 3, 2024
@schuellerf schuellerf removed the Stale label Nov 7, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 8, 2024

This PR is stale because it has been open 30 days with no activity. Remove "Stale" label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Dec 8, 2024
@github-actions GitHub Actions
Copy link

This PR was closed because it has been stalled for 30+7 days with no activity.

@github-actions github-actions bot closed this Dec 16, 2024
@schuellerf schuellerf reopened this Dec 16, 2024
@schuellerf
Makefile: implement "fully source containers" HMS-3883
b2499d1
@schuellerf
Makefile: clean golangci-lint cache on make clean
c6282c1 
To speedup `make lint` we use a local cache.
It seems that there is no sane way to check and just
update the cache, so we'll just provide an option to wipe it.

Using the cache does reduce the time of `make lint` from
1 minute 15sec to 1 sec on my PC. So for consecutive runs,
the cache still makes sense.
@schuellerf schuellerf force-pushed the HMS-3883-fully-source-containers branch from 895cf54 to c6282c1 Compare December 16, 2024 14:20
@github-actions github-actions bot removed the Stale label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcl bcl Awaiting requested review from bcl

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schuellerf @bcl