Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/simplified-installer: fix yq installation on rhel8 #3378

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

runcom
Copy link
Member

@runcom runcom commented Apr 5, 2023

Basically pulls in kislyuk/yq#165 to fix the installation issue

This pull request includes:

  • adequate testing for the new functionality or fixed issue
  • adequate documentation informing people about the change such as

@bcl
Copy link
Contributor

bcl commented Apr 5, 2023

Could you make the commit message a bit more verbose, explain why it needs to be pinned?

@runcom
Copy link
Member Author

runcom commented Apr 5, 2023

Basically pulls in kislyuk/yq#165 to fix the installation issue

forgot to add this to the commit message

Basically use the latest 3.2.1 version because of kislyuk/yq#165

Signed-off-by: Antonio Murdaca <[email protected]>
@runcom
Copy link
Member Author

runcom commented Apr 9, 2023

not sure what's happening with the c9s test (cc @henrywang)

@runcom
Copy link
Member Author

runcom commented Apr 9, 2023

this is still needed to avoid breakages in the future by pinning version - notice main PRs are now passing as they're getting the new version from pip

@bcl
Copy link
Contributor

bcl commented Apr 10, 2023

not sure what's happening with the c9s test

There was a problem with gpg2 defaults that was reverted, but doesn't seem to have made it into whatever packit uses to run things. https://bugzilla.redhat.com/show_bug.cgi?id=2070722

@yih-redhat
Copy link
Contributor

yih-redhat commented Apr 11, 2023

The failure on cs9 is because the fdouser was not created when ansible try to run check with fdouser, then I logon the target vm, and found that the fdouser is created after a few minutes.

  1. Ansible runs at [2023-04-10T23:01:42-04:00]
  2. foduser was created at Apr 10 23:03:30 (about two minutes later)

I'm not sure why it's taking longer than before to create this fdouser on cs9, but I will add a check in script to wait for this user to present.

@bcl
Copy link
Contributor

bcl commented Apr 11, 2023

The failure on cs9 is because the fdouser was not created when ansible try to run check with fdouser,

Take a look at the logs, it's filled with entries like:

Public key for glibc-minimal-langpack-2.34-61.el9.x86_64.rpm is not installed. Failing package is: glibc-minimal-langpack-2.34-61.el9.x86_64
 GPG Keys are configured as: file:///usr/share/distribution-gpg-keys/centos/RPM-GPG-KEY-CentOS-Official

So I would bet that's causing other strange problems.

@thozza thozza enabled auto-merge (rebase) April 24, 2023 10:51
@thozza thozza merged commit 01e7370 into osbuild:main Apr 24, 2023
@runcom runcom deleted the fix-yq-rhel8 branch April 24, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants