Implements the "sameSite"-attribute for the cookie #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- adds the parameter `sameSite` to the `setCookie()`-Function - implements the attribute `sameSite` in the `defaultOptions`-Object (defaultOptions.cookie.sameSite) with the default value of `null` (allowed is `None`, `Lax` and `Strict`) - More information: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Set-Cookie/SameSite
- the `clearStatus()`-Function was missing the `secure`-Parameter
|
What is the reason that this PR does not go through? We need this change to be able to run our application as an embedded application in Microsoft Teams. Now the cookie-consent comes back every time because Teams does not allow cookies without the SameSite filled in. |
|
I guess the maintainer has no interest in PRs. But still not supporting You can use my fork if Maybe @arlogilbert can explain why this PR is not picked up... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sameSiteto thesetCookie()-FunctionsameSitein thedefaultOptions-Object (defaultOptions.cookie.sameSite) with the default value ofnull(allowed isNone,LaxandStrict)