Add financial_losses_pp to PowerPlants assets.

Co-authored-by: Arfima Dev <[email protected]> Co-authored-by: Jose M. Cano <[email protected]> Signed-off-by: Jonathan Yanez Vargas <[email protected]>
os-climate · Aug 8, 2024 · 86f2bae · 86f2bae
1 parent 6551d5c
commit 86f2bae
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 9 deletions.
diff --git a/AUTHORS.rst b/AUTHORS.rst
@@ -5,6 +5,7 @@ Contributors
 * Arfima Dev <[email protected]>
 * Gonzalo Álvarez <[email protected]>
 * Jonathan Yánez <[email protected]>
+* Jose M. Cano <[email protected]>
 * Víctor de Luna <[email protected]>
 * Virginia Morales <[email protected]>
 * Xavier Barrachina <[email protected]>
diff --git a/src/osc_physrisk_financial/assets.py b/src/osc_physrisk_financial/assets.py
@@ -305,7 +305,7 @@ def financial_losses(
         energy_price: float,
         r: Sequence[float],
         n: Optional[int] = 1,
-    ) -> DiscreteRandomVariable:
+    ) -> Union[DiscreteRandomVariable, float]:
         r"""Compute financial losses for a PowerPlant asset.
 
         Parameters
@@ -333,10 +333,5 @@ def financial_losses(
 
 
         """
-        scaled_values = (
-            damages.values * self.value_0 * energy_price * self.discount(r, n)
-        )
-        res = DiscreteRandomVariable(
-            values=scaled_values, probabilities=damages.probabilities.tolist()
-        )
-        return res
+        return self.value_0 * self.discount(r, n) * energy_price * damages
+        # TODO SHOULD BE return self.cash_flows * self.discount(r, n)
diff --git a/src/osc_physrisk_financial/random_variables.py b/src/osc_physrisk_financial/random_variables.py
@@ -353,7 +353,6 @@ def __init__(
                         "Impact bins must be sorted in non-decreasing order."
                     )
                 total_prob = np.sum(probabilities_np)
-                print(total_prob)
                 if not np.isclose(total_prob, 1):
                     if 0 in intervals_np:
                         zero_index = np.where(intervals_np == 0)[0][0]