Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: downgrade go-webauthn #4035

Merged
merged 3 commits into from
Aug 13, 2024
Merged

fix: downgrade go-webauthn #4035

merged 3 commits into from
Aug 13, 2024

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Aug 13, 2024

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@aeneasr aeneasr requested review from zepatrik and hperl as code owners August 13, 2024 09:34
jonas-jonas
jonas-jonas previously approved these changes Aug 13, 2024
Copy link
Member

@jonas-jonas jonas-jonas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did the tests not catch this?

@aeneasr
Copy link
Member Author

aeneasr commented Aug 13, 2024

I‘m not sure, maybe because they are virtual credentials and behave differently?

@jonas-jonas
Copy link
Member

Seems like it.

Another case of "it's a standard, but not really" I guess.

Copy link

codecov bot commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.38%. Comparing base (f7c38f0) to head (7f392e1).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4035      +/-   ##
==========================================
+ Coverage   78.34%   78.38%   +0.04%     
==========================================
  Files         370      370              
  Lines       26120    26120              
==========================================
+ Hits        20463    20474      +11     
+ Misses       4097     4088       -9     
+ Partials     1560     1558       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aeneasr aeneasr self-assigned this Aug 13, 2024
@aeneasr aeneasr added bug Something is not working. blocking Blocks milestones or other issues or pulls. labels Aug 13, 2024
@aeneasr aeneasr force-pushed the down-grade-webauthn-lib branch from d73ac8d to 7f392e1 Compare August 13, 2024 13:36
@aeneasr aeneasr merged commit 4d1954a into master Aug 13, 2024
29 checks passed
@aeneasr aeneasr deleted the down-grade-webauthn-lib branch August 13, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocking Blocks milestones or other issues or pulls. bug Something is not working.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants