Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: deflake session extend config side-effect #3950

Merged
merged 2 commits into from
Jun 13, 2024

Conversation

zepatrik
Copy link
Member

The new test config provider can now read some test values from the context. This allows more tests to be parallel by ensuring isolation between test runs.

@zepatrik zepatrik requested review from aeneasr and hperl as code owners June 13, 2024 11:46
hperl
hperl previously approved these changes Jun 13, 2024
Copy link
Contributor

@hperl hperl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

driver/config/test_config.go Outdated Show resolved Hide resolved
internal/driver.go Outdated Show resolved Hide resolved
aeneasr
aeneasr previously approved these changes Jun 13, 2024
@zepatrik zepatrik dismissed stale reviews from aeneasr and hperl via 51327aa June 13, 2024 12:36
Copy link

codecov bot commented Jun 13, 2024

Codecov Report

Attention: Patch coverage is 91.48936% with 4 lines in your changes missing coverage. Please review.

Project coverage is 78.15%. Comparing base (1bc4dc5) to head (51327aa).
Report is 1 commits behind head on master.

Files Patch % Lines
driver/config/test_config.go 92.85% 1 Missing and 1 partial ⚠️
cmd/hashers/argon2/root.go 0.00% 1 Missing ⚠️
driver/config/config.go 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3950      +/-   ##
==========================================
- Coverage   78.18%   78.15%   -0.04%     
==========================================
  Files         362      363       +1     
  Lines       25433    25453      +20     
==========================================
+ Hits        19885    19893       +8     
- Misses       4028     4037       +9     
- Partials     1520     1523       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aeneasr aeneasr enabled auto-merge (squash) June 13, 2024 13:07
@aeneasr aeneasr merged commit b192c92 into master Jun 13, 2024
26 checks passed
@aeneasr aeneasr deleted the test/deflake-session-extend branch June 13, 2024 13:25
fenech pushed a commit to nbycomp/kratos that referenced this pull request Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants