Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use creds helper #346

Draft
wants to merge 1 commit into
base: v3
Choose a base branch
from
Draft

Conversation

shaxbee
Copy link

@shaxbee shaxbee commented Mar 15, 2022

Support pulling images from registries using docker credentials helper.
Backported auth related changes from go-dockerclient, when image is not found locally and image contains registry name credential helper will be called when available.

Checklist

  • I have read the contributing guidelines
    and signed the CLA.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got green light (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added necessary documentation within the code base (if
    appropriate).

@codecov
Copy link

codecov bot commented Mar 15, 2022

Codecov Report

Attention: Patch coverage is 54.54545% with 5 lines in your changes missing coverage. Please review.

Please upload report for BASE (v3@148c3da). Learn more about missing BASE report.

Files with missing lines Patch % Lines
dockertest.go 54.54% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##             v3     #346   +/-   ##
=====================================
  Coverage      ?   53.64%           
=====================================
  Files         ?        1           
  Lines         ?      343           
  Branches      ?        0           
=====================================
  Hits          ?      184           
  Misses        ?      121           
  Partials      ?       38           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shaxbee
Copy link
Author

shaxbee commented Mar 19, 2022

In order to write automated tests for this PR we would need private image and docker credentials helper provisioned in CI.
I tested it successfully with private images that we're using now :-)

@aeneasr
Copy link
Member

aeneasr commented Mar 22, 2022

Could you show a screen cast of this working with a private repo please? :)

@aeneasr
Copy link
Member

aeneasr commented Apr 11, 2022

ping @shaxbee please see above

@shaxbee shaxbee force-pushed the feat-use-creds-helper branch from 5799eff to e9f3b91 Compare April 26, 2022 07:20
@aeneasr aeneasr marked this pull request as draft July 19, 2022 14:04
@aeneasr
Copy link
Member

aeneasr commented Jul 19, 2022

While the PR is being worked on I will mark it as a draft. That declutters our review backlog :)

Once you're done with your changes and would like someone to review them, mark the PR as ready and request a review from one of the maintainers.

Thank you!

@tmc
Copy link
Contributor

tmc commented Sep 12, 2022

@shaxbee could you follow up here? This is a useful addition.

@vic3lord
Copy link

vic3lord commented Oct 3, 2022

Any news regarding this one?

@tmc tmc mentioned this pull request Mar 8, 2023
GuillaumeSmaha added a commit to GuillaumeSmaha/dockertest that referenced this pull request Aug 2, 2024
chore: add expected header

Rebase of ory#346 and
ory#415
aeneasr pushed a commit that referenced this pull request Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants