Bugfix: Unfocused background page should not be scrollable while modal is open.

[subdavis]

Bug in oruga overrides causes Modal.vue computed -> scrollClass to always be '' which means that the no scroll behavior gets broken when theme-bulma is installed.

---

For what it's worth, I actually think the behavior of computedClass(field: string, defaultValue: string, suffix: string = '') in BaseComponentMixin is kinda bad design.

In order to keep from breaking your component each time oruga adds a customizable class, you'll need to update this repo, which seems quite error prone and appears to be what happened here.

// This line serves no purpose and should be removed
const overrideClass = getValueByPath(config, `${this.$options.configField}.${field}.override`, override)

// ... Later in the file, remove the usage of overrideClass and allow the default value to be used even IF `override = true` if there's no explicit override class defined in the config object.
let appliedClasses = /* ... rewrite this ... */

[jtommy]

Bulma/Buefy adds a class for it, we have to update it

[subdavis]

I've updated the PR to use is-clipped as documented in the bulma modal guide: https://bulma.io/documentation/components/modal/

[subdavis]

Is 01df5ec the right change? This is a pretty big usability bug, LMK how I can help get it resolved. Thank you!

[jtommy]

@subdavis please, remove noScrollClass. As you can see in buefy example there is no need to apply it

[subdavis]

I don't think that's correct.

This is from the buefy modal docs with a modal open: see is-clipped

This is with a no scroll card: see is-noscroll

I don't know what change you're asking for, but if I remove noScrollClass from the config, no class will be applied at all and this is the whole reason for the current bug.

[jtommy]

But you are setting the same class

[subdavis]

I removed noScrollClass