Implement CockroachDB preset #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Codecov Report
@@ Coverage Diff @@
## master #95 +/- ##
===========================================
- Coverage 80.98% 20.18% -60.81%
===========================================
Files 42 43 +1
Lines 1678 1734 +56
===========================================
- Hits 1359 350 -1009
- Misses 165 1326 +1161
+ Partials 154 58 -96
Continue to review full report at Codecov.
|
orlangure
force-pushed
the
cockroachdb
branch
2 times, most recently
from
0fea6c8 to
99dbdcb
Compare
orlangure
force-pushed
the
cockroachdb
branch
4 times, most recently
from
d9eddcc to
34e34dc
Compare
orlangure
force-pushed
the
cockroachdb
branch
from
34e34dc to
8cf90a1
Compare
With this commit, gnomock container will stop trying to create containers when incoming requests are canceled. It will allow to trigger cleanup in more cases than before. Also, this commit removes "debug" flag from some tests. Debug feature has its own tests, so it's not required that other tests use it.
Without this change, when elasticsearch containers were executed together with some other ones, sometimes they were killed (out of memory). Now these containers are limited to 256m which should be enough for tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #92.
This PR adds a new preset -
cockroachdb. It includes basic initial state setup like in other database presets, except for an user/password setup.rootuser without a password is used this preset.To connect to this DB
rootuser without a password should be used with regular go postgres driver (see tests for an example).Another couple of changes that are included here: