GitHub Community
Provide a way to disable emails for deployment reviews per repository/team #14564
Replies: 41 comments 7 replies
-
|
We have another workflow, based on https://devblogs.microsoft.com/devops/i-need-manual-approvers-for-github-actions-and-i-got-them-now/ Every merge to main gets deployed to our development environment. After that, we might want to push that same commit/PR merge to higher environments. As there are no other ways of manual approval/steps/buttons in github actions, we're using GitHub Environments with approvals to make that possible. But we only sometimes do that, not with every PR merge. But we get a lot of emails this way. Therefore, we would like the same as @diastremskii : we'd love the possibility to disable specifically this type of email. |
Beta Was this translation helpful? Give feedback.
-
|
Same here, the manual reviewer workflow for deployments is better UX than manual workflow starts, but we expect the PR owner to make sure everything get's deployed all the way. No reason to send an email every time an manual deployment review is needed as PR owner is expected to make sure someone is approving. |
Beta Was this translation helpful? Give feedback.
-
|
My inbox explodes with those review emails - I want to choose from which teams I would get those review emails or just completely disable those emails. |
Beta Was this translation helpful? Give feedback.
-
|
Same here, we have a workflow that needs manual reviewing but the reviewer pool is huge and we don't want to spam half the company. Please let us turn the notifications off or just notify the author. |
Beta Was this translation helpful? Give feedback.
-
|
My team would love to be able to allow people to review but not send them an email - specifically for deployments to our dev environment. |
Beta Was this translation helpful? Give feedback.
-
|
This is also something we would like. In an org where code changes are 'open' to larger groups of people this feature cannot be used without spamming everybody. For now we have decided we cannot use the deployment approvals feature unless the repo in question is something that needs to be locked down to a smaller group. |
Beta Was this translation helpful? Give feedback.
-
|
+1 one here. |
Beta Was this translation helpful? Give feedback.
-
|
Please add silent option to not spam everybody. |
Beta Was this translation helpful? Give feedback.
-
|
+1 please do this. It's really annoying to get notifications like this |
Beta Was this translation helpful? Give feedback.
-
Additionally, the email contains the above footer suggesting that these notifications can be configured. In reality, there is no such option. |
Beta Was this translation helpful? Give feedback.
-
|
This needs to be addressed, I'm getting bombarded with emails for deployment reviews in repositories I don't work in with no ability to disable these specific notifications without ignoring the entire repo in general (I can't even view these supposed review requests within the notifications inbox in Github itself), despite the email for these emails telling me there's an ability to customize or disable them in the notification settings. |
Beta Was this translation helpful? Give feedback.
-
|
+1, this creates a lot of spam in my email inbox with no way to pick and choose notification options |
Beta Was this translation helpful? Give feedback.
-
|
Yep, most times those "deployment review requested" emails are total waste as the person who just merged will run the deploy also... Please give us a way to turn it off. |
Beta Was this translation helpful? Give feedback.
-
|
Hello,
Ce problème de spamming est connu par l’équipe GitHub Action : #14564
Je vous conseille de créer un autre groupe GitHub ou changer le champs « reviewer » dans le workflow dependabot :
https://github.tools.digital.engie.com/GBSEngieDigitalNemoOpti/CubicwebNemo/blob/0ac35c93fa9f8713c4594b327ab706076a60b410/.github/dependabot.yml#L16
De : Anais ***@***.***>
Envoyé : mercredi 22 mai 2024 11:24
À : community/community ***@***.***>
Cc : BOUVRY Antonin (ENGIE IT) ***@***.***>; Manual ***@***.***>
Objet : Re: [community/community] Provide a way to disable emails for deployment reviews per repository/team (Discussion #14564)
+1 — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread. Message ID: <community/community/repo-discussions/14564/comments/9518988@ github. com>
+1
—
Reply to this email directly, view it on GitHub<https://urldefense.com/v3/__https:/github.com/orgs/community/discussions/14564*discussioncomment-9518988__;Iw!!La4veWw!xnPNr63eNvnuYB917vIdHXnDUbm6k5Oo07q0hyRAiEtXVLBz1pqSIVmxrz1TsBf5-DDC7CMnpBdq5u2EZU08wTu-$>, or unsubscribe<https://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/BGAR7VM6FRXTPN247G45SZDZDRP2DAVCNFSM5S4UMQR2U5DIOJSWCZC7NNSXTOKENFZWG5LTONUW63SDN5WW2ZLOOQ5TSNJRHA4TQOA__;!!La4veWw!xnPNr63eNvnuYB917vIdHXnDUbm6k5Oo07q0hyRAiEtXVLBz1pqSIVmxrz1TsBf5-DDC7CMnpBdq5u2EZchrGzuV$>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.******@***.***>>
ENGIE Mail Disclaimer: http://www.engie.com/disclaimer/
|
Beta Was this translation helpful? Give feedback.
-
|
Same problem here, is this still not resolved? It's 2024 already! |
Beta Was this translation helpful? Give feedback.
-
|
+1 Is there any workaround? |
Beta Was this translation helpful? Give feedback.
-
|
It's ridiculous that it's not implemented yet. Been nearly 2.5 years. +1 from me. |
Beta Was this translation helpful? Give feedback.
-
|
What would everyones preference be, would just having a nested tick box below required reviewers which was 'but don't send them emails' be enough for y'all here? |
Beta Was this translation helpful? Give feedback.
-
I can think of two places (not mutually exclusive): Since the review is on the environment, have an option there. i.e. for this env, notify only these reviewers (in addition to the current "required reviewers" option). |
Beta Was this translation helpful? Give feedback.
-
|
I like @tlgDJPorv and @ashic's ideas. Having a single setting under notifications, kind of as a master control for all and also an option on each environment and/or workflow. Personally, I don't want any notifications right now and would turn the master setting off for myself, but others on my team may want them on specific environments or workflows. |
Beta Was this translation helpful? Give feedback.
-
|
Amazing, thank you all for the engagement and feedback. I cannot say 'we are going to do this right now' but I will go and look to see if any of the 2-3 places y'all have suggested is something we can get done later this year. |
Beta Was this translation helpful? Give feedback.
-
|
@nebuk89 Will this thread be updated when an update is available, or should be look elsewhere for updates? |
Beta Was this translation helpful? Give feedback.
-
|
I will make sure I come back to this thread :) All the PMs across Actions are going to make an effort to be more engaged in our community going forward and to ensure we are listening to you all/talking with you all here. <3 |
Beta Was this translation helpful? Give feedback.
-
|
Any updates on this? |
Beta Was this translation helpful? Give feedback.
-
|
Any update on this |
Beta Was this translation helpful? Give feedback.
and others
-
Hello!
When using the deployment approval flow, by default, all reviewers will receive an email asking to review a deployment.
Example configuration enabling reviews:
When working on a project in a team where everyone can deploy, there is a lot of unnecessary emails being sent because of that. There is also a clear ownership of changes, the same person:
I can understand that emails work for projects where there is a lot of contributors who can’t deploy and a small number of repo maintainers who are able to deploy to production. But for private or GHE projects it's just unnecessary to notify everyone who is able to approve deployments and it generates some annoyance.
Thanks!
Beta Was this translation helpful? Give feedback.
All reactions