-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add itext core metadata and tests #470
Conversation
3b8e332
to
56d623f
Compare
Hi @olpaw , |
Hi @vitali-pr Thanks for the reminder. This got lost in the sea of emails. I will have a look this week. |
@@ -0,0 +1,11 @@ | |||
[ | |||
{ | |||
"latest": true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use either
"latest": true,
or
"default-for": "8\\.0\\..*"
Using them both makes the "default-for"
irrelevant thus potentially confusing.
Same for other index.json
files in your PR.
See https://github.com/oracle/graalvm-reachability-metadata/blob/master/CONTRIBUTING.md
Since 8.x.y is really the latest and you do not have metadata for older versions I suggest you just remove all the "default-for" ...
entries in your index.json
files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pushed the required changes amended with the initial commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR looks clean. Only thing that needs to be changed before merging is to remove the unnecessary use of "default-for": ...
as already mentioned in #470 (comment)
56d623f
to
383cc7f
Compare
@olpaw , I see the failed checks. I didn't add conditions for those io resources intentionally. This is how we use them on java. They are coming with a (separate) font-asian jar. If it's in class path, they are available for a user to load. |
So there are no class files in Even if so ... it should be fine to use
even for the resources in |
But it would be even better if you know of a class that only gets reachable if one of the resources from |
@olpaw , You are right, it will be com.itextpdf.io.font.CidFont then. But the problem is that we don't test these resources using CidFont class. So without a fake CidFont usage in the tests, the tests will just fail in native. Also who knows how users are supposed to use these resources, maybe they'd implement their own FontProgram.
There are no such per cmap classes. |
@vitali-pr your PR is now on master. Thank you for your contribution! |
What does this PR do?
Add itext core metadata and tests
Code sections where the PR accesses files, network, docker or some external service
Checklist before merging