-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
task: Ensure all Python components work with Python 3.12 #1191
Comments
For fixes with newer versions of pip and Python 3.12. Related to #1191
Pendulum 3.0 (https://github.com/sdispater/pendulum/releases/tag/3.0.0) has been released now which I think was the last blocker for Python 3.12 |
It seems sync cannot be used with Python 3.12 due to its dagster dependency which is not 3.12 compliant yet (they even made sure to have pendulum < 3 as dep). |
thanks @gmazoyer, that was one of the main reason to separate it into a dedicated package |
Ok, but if dagster doesn't work with pendulum 3 perhaps we need to handle pendulum differently in the SDK to ensure that the sync project works with the latest SDK version? Were we using dagster or was that some test? |
Good point, it would be good to support both pendulum 2 and 3 if possible, we need to be as flexible as possible in the SDK regarding our dependencies.
It's mainly a test right now but there is a good chance we'll use it in the future |
Based on that I think we should remove dagster for now and look at supporting both pendulum 2 and 3 when we move forward and need it. It seemed like very little had changed with regards to pendulum as seen from the outside. Also looks like they considered ditching pendulum but have been holding off Python 3.12 support for the same reason: dagster-io/dagster#17350 |
I was looking at doing just that. It seems to be easy enough to just remove dagster dependencies now without breaking things.
From our code point of view, this is true. And it does not seem they introduce any breaking changes. |
Addressed with merge 8b23d22 |
Component
API Server / GraphQL, Git Integration
Task Description
No response
The text was updated successfully, but these errors were encountered: