Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task: Ensure all Python components work with Python 3.12 #1191

Closed
ogenstad opened this issue Oct 3, 2023 · 8 comments
Closed

task: Ensure all Python components work with Python 3.12 #1191

ogenstad opened this issue Oct 3, 2023 · 8 comments
Assignees
Labels
group/backend Issue related to the backend (API Server, Git Agent) state/ref This issue is referenced in our internal tooling type/housekeeping Maintenance task type/newcomers Good for newcomers

Comments

@ogenstad
Copy link
Contributor

ogenstad commented Oct 3, 2023

Component

API Server / GraphQL, Git Integration

Task Description

No response

@ogenstad ogenstad added group/backend Issue related to the backend (API Server, Git Agent) type/housekeeping Maintenance task group/python-sdk labels Oct 3, 2023
ogenstad added a commit that referenced this issue Oct 3, 2023
For fixes with newer versions of pip and Python 3.12. Related to #1191
@ogenstad ogenstad mentioned this issue Oct 3, 2023
@BeArchiTek BeArchiTek added the state/ref This issue is referenced in our internal tooling label Nov 14, 2023
@ogenstad
Copy link
Contributor Author

Pendulum 3.0 (https://github.com/sdispater/pendulum/releases/tag/3.0.0) has been released now which I think was the last blocker for Python 3.12

@ogenstad ogenstad added the type/newcomers Good for newcomers label Dec 17, 2023
@ogenstad ogenstad added this to the Alpha #4 milestone Dec 17, 2023
@gmazoyer
Copy link
Contributor

gmazoyer commented Dec 21, 2023

It seems sync cannot be used with Python 3.12 due to its dagster dependency which is not 3.12 compliant yet (they even made sure to have pendulum < 3 as dep).

@dgarros
Copy link
Collaborator

dgarros commented Dec 21, 2023

thanks @gmazoyer, that was one of the main reason to separate it into a dedicated package
I think we can leave the sync plugin for now but it would be good to support 3,12 for the core if possible.

@ogenstad
Copy link
Contributor Author

Ok, but if dagster doesn't work with pendulum 3 perhaps we need to handle pendulum differently in the SDK to ensure that the sync project works with the latest SDK version?

Were we using dagster or was that some test?

@dgarros
Copy link
Collaborator

dgarros commented Dec 22, 2023

Ok, but if dagster doesn't work with pendulum 3 perhaps we need to handle pendulum differently in the SDK to ensure that the sync project works with the latest SDK version?

Good point, it would be good to support both pendulum 2 and 3 if possible, we need to be as flexible as possible in the SDK regarding our dependencies.

Were we using dagster or was that some test?

It's mainly a test right now but there is a good chance we'll use it in the future

@ogenstad
Copy link
Contributor Author

Based on that I think we should remove dagster for now and look at supporting both pendulum 2 and 3 when we move forward and need it. It seemed like very little had changed with regards to pendulum as seen from the outside. Also looks like they considered ditching pendulum but have been holding off Python 3.12 support for the same reason: dagster-io/dagster#17350

@gmazoyer
Copy link
Contributor

Based on that I think we should remove dagster for now and look at supporting both pendulum 2 and 3 when we move forward and need it.

I was looking at doing just that. It seems to be easy enough to just remove dagster dependencies now without breaking things.

It seemed like very little had changed with regards to pendulum as seen from the outside.

From our code point of view, this is true. And it does not seem they introduce any breaking changes.

@dgarros dgarros removed this from the Infrahub - Alpha #4 milestone Jan 8, 2024
@gmazoyer
Copy link
Contributor

Addressed with merge 8b23d22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
group/backend Issue related to the backend (API Server, Git Agent) state/ref This issue is referenced in our internal tooling type/housekeeping Maintenance task type/newcomers Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants