Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes part of #59: Translate binding adapter files to java [BLOCKED: #1514] #1568

Merged
merged 284 commits into from
Aug 17, 2020

Conversation

miaboloix
Copy link
Contributor

@miaboloix miaboloix commented Aug 6, 2020

Explanation

Fixes part of #59: Translate binding adapter files to java

Because kt_android_library() is split into android_library and kt_jvm_library under the hood -- it has been difficult to get custom Binding Adapters in Kotlin to build with Bazel + databinding. The current workaround for this is to translate our binding adapter files to Java so that they can build using android_library(), which now supports databinding. See bazelbuild/rules_kotlin#346 and bazelbuild/bazel#2694

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

miaboloix and others added 30 commits July 21, 2020 13:55
Copy link
Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @miaboloix! Generally LGTM, though there are a few lingering comment threads to resolve before merging into develop.

@BenHenning BenHenning assigned miaboloix and unassigned BenHenning Aug 12, 2020
@miaboloix miaboloix requested a review from anandwana001 August 12, 2020 22:15
Copy link
Contributor

@anandwana001 anandwana001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks @miaboloix

@anandwana001 anandwana001 removed their assignment Aug 13, 2020
@miaboloix miaboloix assigned BenHenning and unassigned miaboloix Aug 17, 2020
Base automatically changed from introduce-domain-bazel-build to develop August 17, 2020 15:44
Copy link
Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @miaboloix! Just had two nits that you can resolve once their corresponding requests are done. Please let me know if I need to clarify anything.

@BenHenning BenHenning assigned miaboloix and unassigned BenHenning Aug 17, 2020
@miaboloix miaboloix merged commit 5d2605e into develop Aug 17, 2020
@miaboloix miaboloix deleted the traslate-binding-adapters-to-java branch August 17, 2020 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants