Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unlisted videos must also be included inside the ZIM #379

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

benoit74
Copy link
Collaborator

@benoit74 benoit74 commented Dec 5, 2024

Unlisted videos have to be considered for ZIM inclusion. The fact they are not listed does not means they are not viewable, see e.g. https://www.youtube.com/playlist?list=PL3rEvTTL-Jm-ZIeAfA6U726nsdYaWn4lL ; all videos are unlisted but anyone knowing the playlist will be able to find the video. Unlisted only refers to the fact that it won't come up in search results or be listed on channel home page. Since we explore by playlist ID, we should always include these videos.

@benoit74 benoit74 added this to the 3.3.0 milestone Dec 5, 2024
@benoit74 benoit74 self-assigned this Dec 5, 2024
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 1.24%. Comparing base (7754caf) to head (fe3f950).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
scraper/src/youtube2zim/youtube.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main    #379   +/-   ##
=====================================
  Coverage   1.24%   1.24%           
=====================================
  Files         11      11           
  Lines       1124    1124           
  Branches     164     164           
=====================================
  Hits          14      14           
  Misses      1110    1110           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benoit74 benoit74 force-pushed the add_unlisted_videos branch from 84e0b95 to fe3f950 Compare December 5, 2024 14:05
@benoit74 benoit74 marked this pull request as ready for review December 5, 2024 14:08
@benoit74 benoit74 merged commit 961570a into main Dec 5, 2024
10 checks passed
@benoit74 benoit74 deleted the add_unlisted_videos branch December 5, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant