-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support django 2.1, DRF 3.9 and use django-filters > 2.0 #173
Conversation
do you think the pr could split up in several ones to handle the relevant issues in each one? |
@auvipy I can't update packages separately, because they are dependent, but I could move addition of python 3.7 to travis and dropping of python 2 support in separate PRs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@imomaliev welcome and thanks for contributing.
1 question: why are you adding a Dockerfile
and a docker-compose.yml
?
We don't have enough resources to maintain those as things change, so if anyone tries to use it at some point in the future and it won't work, I personally won't have time to help them and will refer these users to you. Do you have time to maintain that over time? Consider this factor please, I'm not in favour of adding non essentials which need to be maintained by volunteers which are already over burdened.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@imomaliev welcome and thanks for contributing.
1 question: why are you adding a Dockerfile
and a docker-compose.yml
?
We don't have enough resources to maintain those as things change, so if anyone tries to use it at some point in the future and it won't work, I personally won't have time to help them and will refer these users to you. Do you have time to maintain that over time? Consider this factor please, I'm not in favour of adding non essentials which need to be maintained by volunteers which are already over burdened.
@nemesisdesign I do have time to maintain it. I would suggest having this in repo, because it simplifies setting up development environment for future contributors. But if you and other maintainers are so strongly against it, I will drop them from this PR @auvipy So should I split this PR like I suggested in #173 (comment) ? |
@nemesisdesign @auvipy ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@imomaliev I'm not against having it, I just know that I won't be able to help if someone in the future reports that the docker image is not working.
Could you rebase your PR against the current master?
@nemesisdesign rebased |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@imomaliev I was going to merge but after checking the code I found out something which looks like a minor issue, see below
Thanks @imomaliev @auvipy |
also fixes #170
Fails on python 2. Looks like I need to fix #171 as well. Can someone guide me so that I can drop python 2 support. What should be done I see multiple comments like
Should
GeoJsonDict
be removed?