Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: sd_hash generation and verification (#31) #32

Merged
merged 1 commit into from
Sep 6, 2024
Merged

fix: sd_hash generation and verification (#31) #32

merged 1 commit into from
Sep 6, 2024

Conversation

Abdulbois
Copy link
Contributor

@Abdulbois
fix: sd_hash generation and verification (openwallet-foundation-labs#31)
3acaff0 
- Fix generating `sd_hash` at holder side
- Fix retrieving `sd_hash` at verifier side
- Closes openwallet-foundation-labs#31

Signed-off-by: Abdulbois Tursunov <[email protected]>
@Abdulbois Abdulbois requested a review from jovfer as a code owner September 2, 2024 16:50
c2bo
c2bo approved these changes Sep 4, 2024
View reviewed changes
Copy link

@c2bo c2bo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the test I wrote against a test vector from the sd-jwt draft. Thanks for the quick fix!

@jovfer jovfer merged commit f97e3df into openwallet-foundation-labs:main Sep 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c2bo c2bo c2bo approved these changes

@jovfer jovfer Awaiting requested review from jovfer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Key binding sd_hash computation is incorrect
3 participants
@Abdulbois @c2bo @jovfer