-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extending makefile for OpenVINO, TensorFlow and PyTorch backends #1449
Conversation
|
@@ -1,23 +1,117 @@ | |||
install-onnx-dev: | |||
PYLINT_VERSION := 2.13.9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a widely used practice in Python repos is make style
that fixes code structure and imports automatically. It is based on black and isort. Can we have the same?
Here is an example:
style_check:
black --check .
isort --check .
style:
black .
isort .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AlexKoff88 that it is used in transformers doesn't automatically mean that this is a widely used practice.
It would, however, be nice to have a similar functionality. I considered adding black
before, but the resulting style is pretty much unconfigurable and goes against our current code style at least in terms of used string quoting symbols. Furthermore, black
and isort
frequently conflict with each other, and also running black/isort does not guarantee that pylint will then pass.
I suggest to keep style out of this PR and review the options for style improvements at a later date.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AlexKoff88, @vshampor I will try to cover this aspect in another PR.
38869db
to
dacda25
Compare
dacda25
to
56d9f14
Compare
56d9f14
to
0bd7fd5
Compare
You are absolutely right. Thanks for the comment. |
0bd7fd5
to
6e080df
Compare
run pytorch pre-commit tests |
Changes
Extending makefile for OpenVINO, TensorFlow and PyTorch backends
Reason for changes
Simplify validation process
Related tickets
N/A
Tests
N/A