Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extending makefile for OpenVINO, TensorFlow and PyTorch backends #1449

Merged
merged 3 commits into from
Jan 3, 2023

Conversation

alexsu52
Copy link
Contributor

@alexsu52 alexsu52 commented Dec 21, 2022

Changes

Extending makefile for OpenVINO, TensorFlow and PyTorch backends

Reason for changes

Simplify validation process

Related tickets

N/A

Tests

N/A

@vshampor
Copy link
Contributor

-dev versions should probably install examples too.

@@ -1,23 +1,117 @@
install-onnx-dev:
PYLINT_VERSION := 2.13.9
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a widely used practice in Python repos is make style that fixes code structure and imports automatically. It is based on black and isort. Can we have the same?
Here is an example:

style_check:
	black --check .
	isort --check .

style:
	black .
	isort .

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AlexKoff88 that it is used in transformers doesn't automatically mean that this is a widely used practice.

It would, however, be nice to have a similar functionality. I considered adding black before, but the resulting style is pretty much unconfigurable and goes against our current code style at least in terms of used string quoting symbols. Furthermore, black and isort frequently conflict with each other, and also running black/isort does not guarantee that pylint will then pass.

I suggest to keep style out of this PR and review the options for style improvements at a later date.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AlexKoff88, @vshampor I will try to cover this aspect in another PR.

@alexsu52 alexsu52 force-pushed the as/makefile branch 2 times, most recently from 38869db to dacda25 Compare December 22, 2022 13:18
@alexsu52 alexsu52 marked this pull request as ready for review December 23, 2022 11:38
@github-actions github-actions bot added dependencies Any changes in any dependencies (new dep or its version) should be produced via Change Request on PM documentation Improvements or additions to documentation experimental NNCF Common Pull request that updates NNCF Common NNCF ONNX Pull requests that updates NNCF ONNX NNCF PT Pull requests that updates NNCF PyTorch NNCF TF Pull requests that updates NNCF TensorFlow labels Dec 23, 2022
@github-actions github-actions bot removed NNCF Common Pull request that updates NNCF Common NNCF ONNX Pull requests that updates NNCF ONNX documentation Improvements or additions to documentation NNCF TF Pull requests that updates NNCF TensorFlow experimental NNCF PT Pull requests that updates NNCF PyTorch dependencies Any changes in any dependencies (new dep or its version) should be produced via Change Request on PM labels Dec 23, 2022
@alexsu52
Copy link
Contributor Author

-dev versions should probably install examples too.

You are absolutely right. Thanks for the comment.

Makefile Show resolved Hide resolved
@alexsu52
Copy link
Contributor Author

alexsu52 commented Jan 2, 2023

run pytorch pre-commit tests

@alexsu52 alexsu52 merged commit bc8d48a into openvinotoolkit:develop Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants