Update file anatomy to not use slots #805
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukewarlow
requested review from
gregwhitworth,
andrico1234,
mfreed7 and
dbaron
as code owners
lukewarlow
commented
Aug 19, 2023
| <Part name="label"> | ||
| <Slot name="label" /> | ||
| </Part> | ||
| <Part name="file-selector-button" /> |
There was a problem hiding this comment.
Should this be button type=file-selector to match selectlist? If so should anatomy show pseudos? Or should they be part of the explainer instead?
There was a problem hiding this comment.
Can we wait for selectlist to settle down and progress further before we should really copy anything it did or is doing? I hate to see you adjust this many many times and it's tricky because I feel like we can't say we really know the answer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As #702 decided to not reuse slots this removes the slots from the file anatomy.
The file editors draft also needs updating to not refer to the slots.