Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

udev rules: fix warnings reported by udevadm verify #66

Closed
wants to merge 2 commits into from
Closed

udev rules: fix warnings reported by udevadm verify #66

wants to merge 2 commits into from

Conversation

ldv-alt
Copy link
Contributor

@ldv-alt ldv-alt commented May 17, 2023

Fix the following warnings reported by udevadm verify:

$ udevadm verify */*.rules*
kpartx/dm-parts.rules:35 A comma between tokens is expected.
kpartx/dm-parts.rules: udev rules check failed
multipath/11-dm-mpath.rules:18 Whitespace after comma is expected.
multipath/11-dm-mpath.rules:73 Whitespace after comma is expected.
multipath/11-dm-mpath.rules:73 Whitespace after comma is expected.
multipath/11-dm-mpath.rules:78 Whitespace after comma is expected.
multipath/11-dm-mpath.rules:78 Whitespace after comma is expected.
multipath/11-dm-mpath.rules:78 Whitespace after comma is expected.
multipath/11-dm-mpath.rules: udev rules check failed

5 udev rules files have been checked.
  Success: 3
  Fail:    2

ldv-alt added 2 commits May 17, 2023 20:00
@ldv-alt
dm-parts.rules: fix warning reported by udevadm verify
cadca86 
Fix the following warning reported by udevadm verify:

kpartx/dm-parts.rules:35 A comma between tokens is expected.
kpartx/dm-parts.rules: udev rules check failed

Signed-off-by: Dmitry V. Levin <[email protected]>
@ldv-alt
11-dm-mpath.rules: fix warnings reported by udevadm verify
c7ca67a 
Fix the following warnings reported by udevadm verify:

multipath/11-dm-mpath.rules:18 Whitespace after comma is expected.
multipath/11-dm-mpath.rules:73 Whitespace after comma is expected.
multipath/11-dm-mpath.rules:73 Whitespace after comma is expected.
multipath/11-dm-mpath.rules:78 Whitespace after comma is expected.
multipath/11-dm-mpath.rules:78 Whitespace after comma is expected.
multipath/11-dm-mpath.rules:78 Whitespace after comma is expected.
multipath/11-dm-mpath.rules: udev rules check failed

Signed-off-by: Dmitry V. Levin <[email protected]>
bmarzins
bmarzins reviewed May 19, 2023
View reviewed changes
Copy link
Contributor

@bmarzins bmarzins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look good to me, but in general, pull requests to multipath-tools are handled using an email based workflow. Can you please send these patches to the dm-devel mailing list, and CC mwilck at suse.com and bmarzins at redhat.com? Thanks.

@mwilck mwilck mentioned this pull request May 22, 2023
Merged
@mwilck
Copy link
Contributor

mwilck commented May 24, 2023 •
edited
Loading

I've pushed these commits with some commit message edits to https://github.com/openSUSE/multipath-tools/tree/queue. They will merged with the next multipath-tools release.

@mwilck mwilck mentioned this pull request Jul 5, 2023
Merged
@cvaroqui cvaroqui closed this in #68 Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmarzins bmarzins bmarzins left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ldv-alt @mwilck @bmarzins