Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name-suggestion-index v6 #8305

Merged
merged 58 commits into from
Jul 6, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
58 commits
Select commit Hold shift + click to select a range
b0800c1
Update to name-suggestion-index v5
bhousel Jan 5, 2021
9eb6f87
Update presetIndex to resolve and index locationSets
bhousel Jan 6, 2021
0ad7de0
Move the location index and resolver into a global coreLocations
bhousel Jan 8, 2021
ab85590
Pre-resolve the world locationSet
bhousel Jan 8, 2021
271e1c2
Use locationManager to filter fields/presets/defaults
bhousel Jan 8, 2021
c4daf1b
Use locationManager to resolve/query community index
bhousel Jan 8, 2021
868db88
Have mergeLocationSets work on Objects, add locationSetID property
bhousel Jan 9, 2021
2d8c907
coreLocation tests, documentation
bhousel Jan 11, 2021
d3fb8c6
Upgrade validations outdated_tags, suspicious_names to NSI v5
bhousel Jan 13, 2021
0b3795c
NSI match returns an object now
bhousel Jan 15, 2021
a38a93c
Actually assign the locationSetID properties on the given objects
bhousel Jan 18, 2021
f39f73e
Make sure suggestion preset terms get used in the search
bhousel Jan 18, 2021
4228b65
Support more `*:wikidata` tags for field locking and pin styling
bhousel Jan 18, 2021
74d2825
Fix teh misspellings
bhousel Jan 19, 2021
a325535
`name:pronunciation` is not namelike
bhousel Jan 19, 2021
f61a3ef
Don't replace `flag:name` tag - it's expected to be in local language
bhousel Jan 19, 2021
96298f2
Preserve `name` value if this preset shows `brand` or `operator` field
bhousel Jan 19, 2021
4f369a8
Match the prereleased nsi v5 (for now)
bhousel Jan 22, 2021
11201eb
Rewrite the validator in ES6/Promises, several improvements here:
bhousel Jan 25, 2021
f87c2d9
Allow validators to return provisional results, revalidate after delay
bhousel Jan 26, 2021
16f2f07
Merge pull request #8319 from openstreetmap/promisify_validation
bhousel Jan 27, 2021
3640e15
Fix misspelling "coprorate" -> "corporate"
bhousel Jan 27, 2021
b032cd9
Adust NSI matching validation code:
bhousel Jan 28, 2021
3665f80
Also include `operator:wikidata` as a wikidata tag
bhousel Jan 29, 2021
90bbe38
Remove the brand combo from the name field
bhousel Feb 12, 2021
7694335
Better handling of headGraph, separate head and base queues
bhousel Feb 12, 2021
4d9336b
Checkin en.min.json
bhousel Feb 12, 2021
1f6a212
Move all of NSI into a service, rewrite matcher code
bhousel Mar 3, 2021
42dccbf
When displaying a preset image, use display:none for siblings
bhousel Mar 3, 2021
dc22678
Unsquish the issue messages by adding more side padding
bhousel Mar 3, 2021
bbed217
For some names, consider splitting `name` into `name` and `branch`..
bhousel Mar 5, 2021
1b1bf8e
Don't offer upgrades to dissolved items
bhousel Mar 5, 2021
3f8faec
Improvements to name gathering
bhousel Mar 5, 2021
7a82dba
Only match alternate `amenity/yes` if it actually is tagged that way
bhousel Mar 5, 2021
a656106
Include nsi_dissolved in test setup
bhousel Mar 5, 2021
a827e13
Be less aggressive about removing toplevel tags
bhousel Mar 8, 2021
c3e9e8c
Support a more verbose format for listing issues
bhousel Mar 8, 2021
2b7adf8
Remember user's preference for expanding issue-info section
bhousel Mar 8, 2021
9f30ebf
Adjust verbose utilDisplayLabel call, use for more validation messages
bhousel Mar 10, 2021
19a8fd1
Be smarter about identifying what tree an osm feature might be in
bhousel Mar 11, 2021
2e9c463
update imagery
bhousel Mar 11, 2021
98a622f
Make sure a name is either primary or alternate (can't be both)
bhousel Mar 11, 2021
d282140
If we match a generic name, stop looking
bhousel Mar 11, 2021
f95e7db
Create the categories like the presets
bhousel Mar 12, 2021
3cf5f69
Allow missing locationSetID on presets, fields, categories
bhousel Mar 12, 2021
f5b6024
Revise name/branch splitting code
bhousel Mar 12, 2021
77e7620
Switch to published NSI v5 :tada:
bhousel Mar 22, 2021
55d9da9
Improve logic for matching name fragments like TUI ReiseCenter
bhousel Mar 23, 2021
ec787f8
Location-aware preset matching
bhousel Mar 23, 2021
9537911
Add guard code in `locationsAt`, for testing entities with invalid loc
bhousel Mar 23, 2021
add1143
More sophisticated name/branch splitting
bhousel Mar 24, 2021
0d79e8e
Upgraded to location-conflation v0.8.0
bhousel Mar 28, 2021
3078f95
bump versions
bhousel Jun 6, 2021
896d14b
Upgrade to name-suggestion-index v6
bhousel Jun 24, 2021
bfb36d5
If locationSet is missing `include`, default to worldwide include
bhousel Jul 2, 2021
8db1c1f
Construct URL to match version number that package.json has
bhousel Jul 2, 2021
ba01676
Remove unnecessary context argument
bhousel Jul 2, 2021
d203699
Merge conflicts resolved
mbrzakovic Jul 5, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions css/80_app.css
Original file line number Diff line number Diff line change
Expand Up @@ -1085,7 +1085,7 @@ a.hide-toggle {
visibility: visible;
}
.preset-icon-container.showing-img *:not(.image-icon) {
visibility: hidden;
display: none;
}

.preset-icon-point-border path {
Expand Down Expand Up @@ -3226,11 +3226,11 @@ div.full-screen > button:focus {

.issue-text .issue-icon {
flex: 0 0 auto;
padding: 5px 7px;
padding: 2px 3px;
}
.issue-text .issue-message {
flex: 1 1 auto;
padding: 5px 0;
padding: 4px 5px;
}
.issue-label .issue-autofix {
flex: 0 0 auto;
Expand Down Expand Up @@ -3547,6 +3547,9 @@ li.issue-fix-item button:not(.actionable) .fix-icon {
.issue-container:not(.active) ul.issue-fix-list {
display: none;
}
.issue-container:not(.active) .issue-info {
display: none;
}

.issue-info {
flex: 1 1 auto;
Expand Down Expand Up @@ -5636,4 +5639,4 @@ li.hide + li.version .badge .tooltip .popover-arrow {
height: 100px;
width: 100px;
color: #7092ff;
}
}
8 changes: 4 additions & 4 deletions data/core.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1808,9 +1808,9 @@ en:
message: "{feature} has incomplete tags"
reference: "Some features should have additional tags."
noncanonical_brand:
message: "{feature} looks like a brand with nonstandard tags"
message_incomplete: "{feature} looks like a brand with incomplete tags"
reference: "All features of the same brand should be tagged the same way."
message: "{feature} looks like a common feature with nonstandard tags"
message_incomplete: "{feature} looks like a common feature with incomplete tags"
reference: "Some features, for example retail chains or post offices, are expected to have certain tags in common."
point_as_area:
message: '{feature} should be a point, not an area'
point_as_line:
Expand Down Expand Up @@ -2374,4 +2374,4 @@ en:
wikidata:
identifier: "Identifier"
label: "Label"
description: "Description"
description: "Description"
Loading