Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show what changes are suggested along with the apply button rather than hiding what changes will be done by default #8143

Closed
lgommans opened this issue Oct 31, 2020 · 4 comments · Fixed by #8305

Comments

@lgommans
Copy link

being asked to apply unspecified changes

Rather than asking people to apply unspecified changes and requiring an extra click to see what change you will be making, iD should show what tagging changes it is proposing. Honestly, nobody should be clicking automatic edit buttons unless it's an approved import and their click is part of that approved process, but these tag upgrades are not an import or they could be done mechanically. I'm not proposing an annoying confirmation pop-up or anything, just fold out the proposed changes by default so people can tell, often at a glance, if it is expected and good.

expanded

The sentence "Some features should have additional tags." seems redundant to me, if we want to save some space while we're at it. The info button could be made into a collapse symbol or removed altogether since people can collapse the Issues section if they don't want to see this.

If there is no objection, I could write a patch to resolve this issue.

@lectrician1
Copy link

I like this. I would prefer this format better:
image

@lgommans
Copy link
Author

lgommans commented Nov 1, 2020

@lectrician1 I would like that format too!

@maro-21
Copy link

maro-21 commented Nov 1, 2020

I support this change, because I always click [i] button to expand even though I am experienced with the tags and I usually know what is going to change.

@quincylvania
Copy link
Collaborator

Welcome, @lgommans. I think #6408 covers this…

bhousel added a commit that referenced this issue Mar 8, 2021
This shows the tag diff, and other helpful information about the detected issues.
It is expanded by default now
(closes #6408, closes #8143)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants