Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gui_qt: Add tooltips to dictionary icons #962

Merged
merged 1 commit into from
Jun 5, 2018

Conversation

nsmarkop
Copy link
Contributor

@nsmarkop nsmarkop commented Jun 3, 2018

Fixes #896.

Added tooltips for the cases of

  • loading
  • favorite
  • readonly

I left the error case as-is as it was showing a tooltip with the exception already. I wasn't sure on the exact messages to include in the tooltips, so I just took a shot at a short description of each state.

I ran python setup.py extract_messages to update the plover.pot file to include these new strings as well. It made some other changes outside of just line numbers for strings that have been added or no longer appear anywhere else; these appear fine at first glance to me.

@benoit-pierre
Copy link
Member

Can you leave out the changes to plover.pot?

@nsmarkop nsmarkop reopened this Jun 5, 2018
@nsmarkop
Copy link
Contributor Author

nsmarkop commented Jun 5, 2018

Updated to remove the plover.pot changes.

@morinted morinted merged commit e66222a into openstenoproject:master Jun 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create tooltips for dictionary status icons
3 participants