Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update commands and OS versions in GitHub Actions #1598

Merged

Conversation

mkrnr
Copy link
Contributor

@mkrnr mkrnr commented Mar 12, 2023

Summary of changes

The goal of this PR is to fix all deprecation warnings that we currently have in our GitHub Action runs, see for example the latest run on master:

  • replaces the deprecated set-output command, see GitHub Blog
  • updates all imported GitHub Actions such as actions/cache to remove related deprecation warnings
  • updates deprecated macos-10.15 version in GitHub Actions
  • updates windows-2019 version in GitHub Actions because why not

See this run which does not show any warnings.

Pull Request Checklist

  • Changes have tests
  • News fragment added in news.d. See documentation for details

mkrnr added 2 commits March 12, 2023 10:26
* replaces the deprecated set-output command, see https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
* updates all imported GitHub Actions such as actions/cache to remove related deprecation warnings
* fixes a deprecation warning for macos-10.15
* also updates Windows because why not
@mkrnr mkrnr force-pushed the update-gh-actions-set-output-command branch from d05663d to 29878f8 Compare March 12, 2023 09:44
@mkrnr
Copy link
Contributor Author

mkrnr commented Apr 28, 2023

@sammdot this PR as well as #1599 are ready for review whenever you find the time.

Please also have a look at this discord post (in #plover-dev on April 19th) if you haven't already.

Thanks a lot!

@sammdot sammdot merged commit d5386f8 into openstenoproject:master Jul 14, 2023
@mkrnr mkrnr deleted the update-gh-actions-set-output-command branch July 15, 2023 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants