Better steno errors handling #1501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`normalize_stroke`, `normalize_steno`, and `steno_to_sort_key` now default to strict mode, and don't log errors anymore.
Only one helper for now: `StenoNormalizer`; to be used by dictionary implementation to notify about invalid steno errors during load. Instead of (potentially) spamming the notification area with errors, only notify once in case of errors, with the number of errors and dictionary name.
Add an error icon to those.
benoit-pierre
force-pushed
the
better_steno_errors_handling
branch
from
2e32d5a to
901261e
Compare
|
I changed the error into a warning, since it's not critical. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
change
normalize_stroke,normalize_steno, andsteno_to_sort_keydefault to strict mode, and stop logging errors.add an helper for dictionary implementations to log invalid steno errors on load: there is only one notification in case of errors (instead of potentially spamming the notification area), and the message includes the dictionary name and number of errors:
Pull Request Checklist