gui_qt/paper_tape: fix save feature #1434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morinted
requested changes
Nov 4, 2021
benoit-pierre
force-pushed
the
fix_paper_tape_save_feature
branch
from
00b0904 to
ce07991
Compare
morinted
approved these changes
Nov 4, 2021
Because the work was split in 3 different PRs. Those will be merged automatically by towncrier: And I've not made this PR a different bugfix entry because the changelog is still describing the differences with the latest non-continuous release (v4.0.0.dev10). |
|
Thanks. That helps and of course it doesn't make sense to say we fixed something that was never released. |
antistic
pushed a commit
to antistic/plover
that referenced
this pull request
Jan 23, 2022
…_tape_save_feature gui_qt/paper_tape: fix save feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Fix regression introduced in #1308.
Closes #1433.
Pull Request Checklist