Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTF/CRE rework + small C extension to tokenize RTF #1365

Conversation

benoit-pierre
Copy link
Member

Summary of changes

This add a C extension to tokenize RTF (the parsing is still done in Python), this would bring the speed gains (with #1362, same dictionary) to ~5.3.

The problem: no more universal wheel for Plover! No universal wheel, mean installing from source unless a wheel for the correct platform / interpreter version is available, which means PyQt5 must be installed for building the UI. This would make installing Plover more difficult on things like a Raspberry Pi.

Possible fix: move the RTF/CRE support to a dedicated external plugin, like we did with Treal.

@user202729
Copy link
Member

There remains an option to provide a pure Python plugin, and a C extension plugin. But that's more maintenance work.

Otherwise, I assume that you would remove the Python implementation (before the import)?

@benoit-pierre
Copy link
Member Author

Or just make a small standalone rtf_tokenize package and depend on that (like for plover_stroke in #1362).

@benoit-pierre benoit-pierre force-pushed the rtf_rework_with_c_extension branch from 2a778a9 to 908245c Compare October 11, 2021 18:34
@benoit-pierre
Copy link
Member Author

Updated to use a dedicated rtf_tokenize package with the C extension.

@gdwaynewarner
Copy link

gdwaynewarner commented Oct 11, 2021 via email

@benoit-pierre
Copy link
Member Author

Common @gdwaynewarner, you know the drill: create a dedicated PR with the relevant information (image is missing).

@gdwaynewarner
Copy link

gdwaynewarner commented Oct 11, 2021 via email

@benoit-pierre benoit-pierre merged commit 0dd3df1 into openstenoproject:master Oct 26, 2021
@benoit-pierre benoit-pierre deleted the rtf_rework_with_c_extension branch October 26, 2021 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants