Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rework dictionaries widget #1332

Merged
merged 13 commits into from
Oct 9, 2021
Merged

rework dictionaries widget #1332

merged 13 commits into from
Oct 9, 2021

Conversation

benoit-pierre
Copy link
Member

@benoit-pierre benoit-pierre commented May 23, 2021 •
edited
Loading

Summary of changes

  • initially part of Improve accessibility #1308, change the widget to use a list with a custom model instead of table
  • add preliminary support for testing the Qt GUI (only the dictionaries widget for now)
  • tweak the widget context menu to only trigger on the list (and not other parts of the frame, like the toolbar)

Note: this drop the custom test command, as the custom argument list handling make using some pytest options impossible (e.g. -m gui_qt), and the workaround for pytest cache handling is not necessary anymore.

Pull Request Checklist

  • Changes have tests
  • News fragment added in news.d. See documentation for details

@benoit-pierre
pytest: add configuration
9602552
@benoit-pierre
tox: use pytest directly
f7af10d
@benoit-pierre
ci: use pytest directly
0f509b4
@benoit-pierre
setup: drop custom test command
aa12d59 
The workaround for `pytest` caching issues is not needed anymore,
and the custom command line handling conflicts when using `-m markexpr`.
@benoit-pierre
build_utils/setup: drop custom test command
6446f29
@benoit-pierre
test: add support for gui_qt tests
22dfb93
@benoit-pierre
config: tweak DictionaryConfig.__repr__
0449fab
@benoit-pierre
gui_qt/dictionaries: rework widget
a1b621e 
Switch to a list view with a custom model.
@benoit-pierre
gui_qt/main_window: minor cleanup
d5447a9
@benoit-pierre
gui_qt/dictionaries: tweak context menu
2b22bfd 
To only trigger on the list view, and not other parts of the frame
(like the toolbar).
@benoit-pierre
gui_qt/dictionaries: tweak code to make testing easier
9cd7e7a
@benoit-pierre
tests: add some tests for the dictionaries widget
65244d6
@benoit-pierre
add news entry
9284cca
@benoit-pierre benoit-pierre mentioned this pull request May 23, 2021
Merged
2 tasks
@benoit-pierre benoit-pierre mentioned this pull request Jun 21, 2021
Merged
4 tasks
@benoit-pierre benoit-pierre merged commit 99e3d54 into openstenoproject:master Oct 9, 2021
@benoit-pierre benoit-pierre deleted the dictionaries_widget_rework branch October 9, 2021 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@benoit-pierre