Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve config handling #1123

Merged
merged 9 commits into from
Apr 17, 2020
Merged

Conversation

benoit-pierre
Copy link
Member

@benoit-pierre benoit-pierre commented Apr 10, 2020

Summary of changes

  • simplify the load/save API
  • ensure save operations are atomic
  • save on config changes, instead of (always) on exit
  • support ~/.config/plover on Linux (it's given priority over ~/.local/share/plover)

Closes #674, #915, and #1097.

Pull Request Checklist

  • Changes have tests
  • News fragment added in news.d. See documentation for details

Use `resource_update` helper.
By first writing to a temporary file before replacing the original.
Instead, save it on engine configuration change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Config file in wrong directory on Linux
2 participants