Show dictionary on add translation #1084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When adding new or checking existing stroke, definitions the dialog box shows also the dictionary file name excluding the path of the current mapping if exists. It also lists other mappings if present in other dictionaries. Translation text style is changed to bold for better visiblity.
Added tests for lookup_from_all. A bug was also found in the filtering of key value pairs in the dictionary collection lookup-function that was not picked up by the tests due to wrong assertion. If a value was fitterred out from one dictionary, no other value were returned even if a value that is not supposed to be filtered out appears in a different dictionary. The filtering is now fixed.
|
I'm excited about this PR! Some screenshots Before:
After:
Struggling with the "It is also mapped to:" sentence, wondering if we should consider something like…
Do we want to consider a different format, too? Something with less English:
With the dictionary text color maybe a gray so that the translations stand out. |
|
My previous screenshots didn't include the bold font present in the PR
|
|
I made my suggested changes, the result is |
morinted
reviewed
Oct 14, 2020
morinted
approved these changes
Oct 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding new or checking existing stroke, the add translation dialog did not show in which dictionary mapped entries belong to.
On the add translation dialog, the mapping information on the stokes written to the "Strokes" text box will now show the dictionary in which the currently used mapping is defined as well as other mappings found in other dictionaries. This also fixes bug in which filtering from one dictionary mapping prevented other mappings to be used from other dictionaries.