-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add verify-lint-fix to API lint check #59951
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/pj-rehearse |
@JoelSpeed: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Rehearsal failed as it could not look up the master commit for the API repo. PULL_BASE_SHA is set to the release repo, and not the API repo. I don't think there's a way to actually rehearse this. |
7dc89a7
to
56fee11
Compare
56fee11
to
312e488
Compare
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
/pj-rehearse |
@JoelSpeed: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
/test ordered-prow-config |
@JoelSpeed: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This adds the
verify-lint-fix
to the lint target for the openshift API repo.The lint fix will apply auto-fixes, currently, those which we can auto-fix, are enabled for auto-fixing. The auto-fixes that are not enabled are because they cannot easily be argued to be compatible fixes.
This should enforce that all fixes are applied before the PR is merged, keeping up the standards within the repo.