feat: move tolerations into LVMCluster.Spec #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbalacha
requested review from
leelavg and
sp98
and removed request for
leelavg
This commit moves tolerations out of the individual deviceClasses and into the main LVMCluster spec Signed-off-by: N Balachandran <[email protected]>
The topolvm-node daemonset toleration will now be the same as that of the vgmanager daemonset. Signed-off-by: N Balachandran <[email protected]>
sp98
reviewed
Jan 17, 2022
| @@ -25,11 +25,13 @@ import ( | |||
| // extractNodeSelectorAndTolerations combines and extracts scheduling parameters from the multiple deviceClass entries in an lvmCluster | |||
| func extractNodeSelectorAndTolerations(lvmCluster *lvmv1alpha1.LVMCluster) (*corev1.NodeSelector, []corev1.Toleration) { | |||
| var nodeSelector *corev1.NodeSelector | |||
| var tolerations []corev1.Toleration | |||
|
|
|||
| tolerations := lvmCluster.Spec.Tolerations | |||
There was a problem hiding this comment.
how about just returning lvmCluster.Spec.Tolerations from this method and not saving it in a variable first. The variable is never used.
There was a problem hiding this comment.
While that is a valid comment,I would like to address that in a separate PR
jmolmo
approved these changes
Jan 17, 2022
sp98
approved these changes
Jan 17, 2022
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jmolmo, nbalacha, sp98 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the tolerations field out of the deviceClass and into the main LVMCluster.Spec.
It also updates the tolerations in topolvm-node daemonset to match that of the vgmanager daemonset.