Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Update cert expiry to 10 years #74

Merged
merged 1 commit into from
Jan 17, 2022

Conversation

sp98
Copy link
Contributor

@sp98 sp98 commented Jan 17, 2022

Current cert expiry is 356 days. This PR updates the expiry to 3560
days.

Signed-off-by: Santosh Pillai [email protected]

@sp98 sp98 requested review from nbalacha and leelavg January 17, 2022 14:03
Current cert expiry is 356 days. This PR updates the expiry to 3560
days.

Signed-off-by: Santosh Pillai <[email protected]>
Copy link
Contributor

@leelavg leelavg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 17, 2022
@sp98 sp98 force-pushed the extend-cert-expiry branch from 8b2b225 to 85c42ec Compare January 17, 2022 14:08
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 17, 2022
Copy link
Contributor

@nbalacha nbalacha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is fine. Please modify the commit message to satisfy commitlint requirements.

@sp98
Copy link
Contributor Author

sp98 commented Jan 17, 2022

Code is fine. Please modify the commit message to satisfy commitlint requirements.

done.

@sp98 sp98 requested a review from nbalacha January 17, 2022 14:10
@nbalacha
Copy link
Contributor

/lgtm
/approved

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 17, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 17, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: leelavg, nbalacha, sp98

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nbalacha nbalacha merged commit b2aa645 into openshift:main Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants