[release-4.15] OCPBUGS-28966: fix: more sophisticated tagging migration

[jakobmoellerdev]

This PR solves 2 main issues:

1. The tagging migration used lvs that were already prefiltered by the tag
2. The tagging migration was using inefficient querying and always ran for all lvs, that now changed.

The test cases didnt reach all the paths so we didnt catch that.

[openshift-ci-robot]

@jakobmoellerdev: This pull request references Jira Issue OCPBUGS-26768, which is invalid:

• expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead
• expected Jira Issue OCPBUGS-26768 to depend on a bug targeting a version in 4.16.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This PR solves 2 main issues:

1. The tagging migration used lvs that were already prefiltered by the tag
2. The tagging migration was using inefficient querying and always ran for all lvs, that now changed.
3. The test cases didnt reach all the paths so we didnt catch that.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakobmoellerdev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jakobmoellerdev]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov-commenter]

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (2497a69) 81.45% compared to head (197fc7e) 81.85%.

Additional details and impacted files

@@               Coverage Diff                @@
##           release-4.15     #568      +/-   ##
================================================
+ Coverage         81.45%   81.85%   +0.40%     
================================================
  Files                24       24              
  Lines              1790     1835      +45     
================================================
+ Hits               1458     1502      +44     
  Misses              225      225              
- Partials            107      108       +1     

Files	Coverage Δ
internal/controllers/vgmanager/controller.go	75.26% <100.00%> (ø)
internal/controllers/vgmanager/status.go	80.70% <100.00%> (ø)
internal/controllers/vgmanager/lvm/lvm.go	99.10% <92.00%> (-0.90%)	⬇️
internal/tagging/tagging.go	83.01% <82.97%> (+16.35%)	⬆️

[jakobmoellerdev]

/test precommit-check

[jakobmoellerdev]

/test lvm-operator-e2e-aws-sno

[openshift-ci]

@jakobmoellerdev: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[suleymanakbas91]

/lgtm

[openshift-ci-robot]

@jakobmoellerdev: This pull request references Jira Issue OCPBUGS-28966, which is invalid:

• expected Jira Issue OCPBUGS-28966 to depend on a bug targeting a version in 4.16.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This PR solves 2 main issues:

1. The tagging migration used lvs that were already prefiltered by the tag
2. The tagging migration was using inefficient querying and always ran for all lvs, that now changed.

The test cases didnt reach all the paths so we didnt catch that.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@jakobmoellerdev: Jira Issue OCPBUGS-28966: All pull requests linked via external trackers have merged:

• openshift/lvm-operator#568

Jira Issue OCPBUGS-28966 has been moved to the MODIFIED state.

In response to this:

This PR solves 2 main issues:

1. The tagging migration used lvs that were already prefiltered by the tag
2. The tagging migration was using inefficient querying and always ran for all lvs, that now changed.

The test cases didnt reach all the paths so we didnt catch that.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.