-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPEDGE-810: chore: remove pre 4.16 components from cluster on startup #564
OCPEDGE-810: chore: remove pre 4.16 components from cluster on startup #564
Conversation
@jakobmoellerdev: This pull request references OCPEDGE-810 which is a valid jira issue. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Skipping CI for Draft Pull Request. |
d053f55
to
c50c302
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jakobmoellerdev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
9e2edfb
to
c15097b
Compare
@jakobmoellerdev: This pull request references OCPEDGE-810 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Signed-off-by: Jakob Möller <[email protected]>
c15097b
to
5ae53f1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #564 +/- ##
==========================================
+ Coverage 81.74% 82.33% +0.58%
==========================================
Files 24 25 +1
Lines 1819 1868 +49
==========================================
+ Hits 1487 1538 +51
+ Misses 218 217 -1
+ Partials 114 113 -1
|
/override ci/prow/precommit-check |
@jakobmoellerdev: Overrode contexts on behalf of jakobmoellerdev: ci/prow/precommit-check In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@jakobmoellerdev: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/lgtm |
Removes 4.16 Components (topolvm controller, topolvm node daemonset, and leftover leases) from the cluster if they are still there as they wouldnt get removed by OLM during upgrades.