-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-4.15] OCPBUGS-26768: Revert back to file-based lvmd config to support different configs for each node #556
[release-4.15] OCPBUGS-26768: Revert back to file-based lvmd config to support different configs for each node #556
Conversation
This reverts commit faed224.
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: suleymanakbas91 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
60c1819
to
e5b4a61
Compare
Signed-off-by: Suleyman Akbas <[email protected]>
e5b4a61
to
3614a74
Compare
/test all |
@suleymanakbas91: This pull request references Jira Issue OCPBUGS-26768, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@suleymanakbas91: This pull request references Jira Issue OCPBUGS-26768, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## release-4.15 #556 +/- ##
================================================
- Coverage 81.78% 81.45% -0.34%
================================================
Files 24 24
Lines 1795 1790 -5
================================================
- Hits 1468 1458 -10
- Misses 223 225 +2
- Partials 104 107 +3
|
/lgtm |
/remove-label jira/invalid-bug |
@suleymanakbas91: Can not set label jira/valid-bug: Must be member in one of these teams: [openshift-patch-managers openshift-staff-engineers openshift-release-oversight] In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@suleymanakbas91: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@suleymanakbas91: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@suleymanakbas91: Jira Issue OCPBUGS-26768: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-26768 has been moved to the MODIFIED state. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
No description provided.