-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-4.15] OCPBUGS-27358: fix: add missing permissions to cluster scoped resources #549
[release-4.15] OCPBUGS-27358: fix: add missing permissions to cluster scoped resources #549
Conversation
Signed-off-by: Jakob Möller <[email protected]> (cherry picked from commit ac3ea44) Signed-off-by: Jakob Möller <[email protected]>
@jakobmoellerdev: This pull request references Jira Issue OCPBUGS-27358, which is valid. The bug has been moved to the POST state. 6 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-4.15 #549 +/- ##
=============================================
Coverage 81.78% 81.78%
=============================================
Files 24 24
Lines 1795 1795
=============================================
Hits 1468 1468
Misses 223 223
Partials 104 104 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jakobmoellerdev, suleymanakbas91 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@jakobmoellerdev: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
a312ffe
into
openshift:release-4.15
@jakobmoellerdev: Jira Issue OCPBUGS-27358: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-27358 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
(cherry picked and adjusted from commit ac3ea44)