NO-JIRA: Must-Gather, Running gather scripts in background

[OdedViner]

The collection scripts can be executed in parallel to save time when running the MG.

Process:
1.Running gather scripts in parallel
2.Waiting for the subprocesses to finish execution.

[openshift-ci]

Welcome @OdedViner! It looks like this is your first PR to openshift/lvm-operator 🎉

[openshift-ci]

Hi @OdedViner. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jakobmoellerdev]

Hi @OdedViner, QQ: what happens if we have an exit code in any of these runs? will the other parts abort? Also I am wondering how long the run takes for your case and how much savings you were able to achieve. Of course we are happy for the improvement, but if the benefit is negligible or introduces side effects we may have to think about it twice.

[OdedViner]

Hi @OdedViner, QQ: what happens if we have an exit code in any of these runs? will the other parts abort? Also I am wondering how long the run takes for your case and how much savings you were able to achieve. Of course we are happy for the improvement, but if the benefit is negligible or introduces side effects we may have to think about it twice.

Hi @jakobmoellerdev , I built a private image with my code quay.io/oviner/ocs-must-gather:lvm_mg
Can you try to compare mg like here?
openshift/must-gather#399

time oc adm must-gather --image=quay.io/lvms_dev/lvms-must-gather:latest


time oc adm must-gather --image=quay.io/oviner/ocs-must-gather:lvm_mg

[jakobmoellerdev]

/ok-to-test

[jakobmoellerdev]

/override ci/prow/snyk-deps

@suleymanakbas91 https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_lvm-operator/534/pull-ci-openshift-lvm-operator-main-snyk-deps/1744310919162236928 failed due to a Vuln issue, proposing a fix there later.

[openshift-ci]

@jakobmoellerdev: Overrode contexts on behalf of jakobmoellerdev: ci/prow/snyk-deps

In response to this:

/override ci/prow/snyk-deps

@suleymanakbas91 https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_lvm-operator/534/pull-ci-openshift-lvm-operator-main-snyk-deps/1744310919162236928 failed due to a Vuln issue, proposing a fix there later.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@OdedViner: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci-robot]

@OdedViner: This pull request explicitly references no jira issue.

In response to this:

The collection scripts can be executed in parallel to save time when running the MG.

Process:
1.Running gather scripts in parallel
2.Waiting for the subprocesses to finish execution.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[jakobmoellerdev]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakobmoellerdev, OdedViner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jakobmoellerdev]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment