OCPVE-760: Save lvmd config to a configmap instead of a file

[suleymanakbas91]

This PR changes the way how VG Manager supplies lvmd config to TopoLVM Node. The config file was saved as a file on the host before. Now, VG Manager creates a ConfigMap that is mounted to TopoLVM Node. This way, TopoLVM does not need the file-checker init-container anymore, hence it is deleted.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[suleymanakbas91]

/test all

[jakobmoellerdev]

Looks great :)

Just one question: what happens with lvmd when the file / configmap is gone?

If you interact with config maps in the controller (especially if you do it on every reconciel), I think you should cache them and restrict the cache to the namespace that the operator is deployed in. Even if lvmd works fine still, we probably need to add a watch to namespaced config maps to react and reconcile in case of deletion requests?

Other than that we are good to go I think 🚀

[openshift-ci-robot]

@suleymanakbas91: This pull request references OCPVE-760 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[codecov-commenter]

Codecov Report

Merging #480 (faed224) into main (7499d08) will increase coverage by 0.24%.
Report is 8 commits behind head on main.
The diff coverage is 87.50%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #480      +/-   ##
==========================================
+ Coverage   81.93%   82.17%   +0.24%     
==========================================
  Files          24       24              
  Lines        1771     1784      +13     
==========================================
+ Hits         1451     1466      +15     
+ Misses        219      218       -1     
+ Partials      101      100       -1     

Files	Coverage Δ
internal/controllers/vgmanager/controller.go	77.14% <87.50%> (+0.91%)	⬆️

... and 2 files with indirect coverage changes

[openshift-ci-robot]

@suleymanakbas91: This pull request references OCPVE-760 which is a valid jira issue.

In response to this:

This PR changes the way how VG Manager supplies lvmd config to TopoLVM Node. The config file was saved as a file on the host before. Now, VG Manager creates a ConfigMap that is mounted to TopoLVM Node. This way, TopoLVM does not need the file-checker init-container anymore, hence it is deleted.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jakobmoellerdev]

/lgtm
💯

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakobmoellerdev, suleymanakbas91

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jakobmoellerdev,suleymanakbas91]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[suleymanakbas91]

/retest

[openshift-ci]

@suleymanakbas91: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.